Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cell execution time information -- make compatible with upstream #3983

Closed
williamstein opened this issue Jul 31, 2019 · 3 comments
Closed

cell execution time information -- make compatible with upstream #3983

williamstein opened this issue Jul 31, 2019 · 3 comments

Comments

@williamstein
Copy link
Contributor

Just saw this:

jupyter/nbformat#144

We could change our code, which also stores timing, to be compatible.

@williamstein
Copy link
Contributor Author

Yes, we should definitely try to do this!

@williamstein
Copy link
Contributor Author

I just looked and our cell timing implementation right now SUCKS! I don't know what happened, but it's really bad because the information about when a cell was executed and how long it took to compute is actually stored nowhere! If you refresh your browser it is just gone. That's terrible.

So adding the info in the same way as in jupyterlab and also just storing it at all is something we definitely need to do soon.

@williamstein
Copy link
Contributor Author

I was fortunately just completely wrong in my comment #3983 (comment) since the start and end time are stored in our core notebook data structure:

image

We know when the cell was run, when it stopped running, and it is all persisted. It's in the start/end fields.

Also, the upstream execution time is defined here https://github.com/jupyter/nbformat/blob/main/nbformat/v4/nbformat.v4.5.schema.json#L223
but it seems to be really low level and far too detailed. There can be hundreds of messages for a given cell output, and storing all that is something nobody needs, at least not by default. So we're storing something much, much simpler in cocalc, hence there's no compatibility to be gained here. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant