fix #5269 -- this might fix an issue with opts.cb in the hub

sagemathinc · Apr 11, 2021 · ecbf1d7 · ecbf1d7
1 parent a0a8686
commit ecbf1d7
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/src/smc-hub/postgres-base.coffee b/src/smc-hub/postgres-base.coffee
@@ -435,7 +435,7 @@ class exports.PostgreSQL extends EventEmitter    # emits a 'connect' event whene
 
         # quick check for write query against read-only connection
         if @is_standby and (opts.set? or opts.jsonb_set? or opts.jsonb_merge?)
-            opts.cb("set queries against standby not allowed")
+            opts.cb?("set queries against standby not allowed")
             return
 
         if opts.retry_until_success
@@ -450,7 +450,7 @@ class exports.PostgreSQL extends EventEmitter    # emits a 'connect' event whene
                 cb       : (err) =>
                     if err
                         dbg("FAILED to connect -- #{err}")
-                        opts.cb("database is down (please try later)")
+                        opts.cb?("database is down (please try later)")
                     else
                         dbg("connected, now doing query")
                         @__do_query(opts)
@@ -475,9 +475,9 @@ class exports.PostgreSQL extends EventEmitter    # emits a 'connect' event whene
         # calls the original cb.
         retry_opts.cb = (err) =>
             if err
-                orig_cb(err)
+                orig_cb?(err)
             else
-                orig_cb(args...)
+                orig_cb?(args...)
 
         # OK, now start it attempting.
         misc.retry_until_success(retry_opts)