Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more prefixes to some labels #174

Merged
merged 3 commits into from
Feb 4, 2023
Merged

Conversation

tobiasdiez
Copy link

I was not able to test it...

@mkoeppe mkoeppe merged commit 3bda081 into sagemath:master Feb 4, 2023
@tobiasdiez tobiasdiez deleted the update-labels branch February 4, 2023 06:51
@kwankyu
Copy link

kwankyu commented Feb 4, 2023

Here "pending" has prefix "s: ", while in the previous discussion, "pending" has no prefix according to #99 (comment).

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

I am okay with either way for now.

@mkoeppe
Copy link

mkoeppe commented Feb 4, 2023

I'll have to run another round of imports tomorrow, so this can still be fixed. PR?

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

I am preparing a PR. "pending" is missing in label_colors. Is it okay or should I add?

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

"t: feature" is not in label_colors too.

@kwankyu
Copy link

kwankyu commented Feb 4, 2023

On the other hand, we have "resolution" in label_colors. But we don't have "resolution" label. Right?

@mkoeppe
Copy link

mkoeppe commented Feb 4, 2023

resolution is a "label_category"; this color affects all labels that are created when mapping Trac resolutions - https://github.com/sagemath/trac-to-github/blob/master/migrate.py#L2362

@mkoeppe
Copy link

mkoeppe commented Feb 5, 2023

After these PRs, unfortunately labels / colors are messed up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants