Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pseudomorphisms #38650

Open
wants to merge 42 commits into
base: develop
Choose a base branch
from

Conversation

xcaruso
Copy link
Contributor

@xcaruso xcaruso commented Sep 12, 2024

This PR implements pseudomorphisms.

Let $M, M'$ be modules over a ring $R$, $\theta: R \to R$ be a ring homomorphism, and $\delta: R \to R$ be a $\theta$-derivation, which is a map such that $\delta(xy) = \theta(x)\delta(y) + \delta(x)y$.
A pseudomorphism $f : M \to M$ is an additive map such that $f(\lambda x) = \theta(\lambda)f(x) + \delta(\lambda) x$ for all $\lambda$ and $x$.

This PR is based on a former PR by @ymusleh (that I could not find, I don't know why).

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Copy link

github-actions bot commented Sep 12, 2024

Documentation preview for this PR (built with commit 76b71cf; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@xcaruso xcaruso mentioned this pull request Sep 23, 2024
5 tasks
@xcaruso xcaruso requested a review from kryzar September 23, 2024 16:35
@xcaruso
Copy link
Contributor Author

xcaruso commented Nov 17, 2024

I tried to fix the test suite. Doing this, I noticed some problems with categories; they are now fixed.

@xcaruso
Copy link
Contributor Author

xcaruso commented Feb 11, 2025

@kryzar Please tell me if you have some comment on this PR.

Copy link
Contributor

@kryzar kryzar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are some suggestions to enhance the doc:

src/sage/modules/free_module_pseudohomspace.py Outdated Show resolved Hide resolved
src/sage/modules/free_module_pseudohomspace.py Outdated Show resolved Hide resolved
src/sage/modules/free_module.py Show resolved Hide resolved
@xcaruso xcaruso added the sd128 tickets of Sage Days 128 Le Teich label Feb 13, 2025
@kryzar kryzar self-requested a review February 13, 2025 19:03
@kryzar
Copy link
Contributor

kryzar commented Feb 14, 2025

Thanks Xavier!
The two failing tests do not seem to be related to this ticket.
PR approved.

@kryzar
Copy link
Contributor

kryzar commented Feb 14, 2025

Also, thank you @ymusleh for the original contribution!

@xcaruso
Copy link
Contributor Author

xcaruso commented Feb 15, 2025

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants