-
-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get rid of one sage_eval in complex numbers #38391
Conversation
Documentation preview for this PR (built with commit 191dd38; changes) is ready! 🎉 |
Depends on how much external code uses the string constructor of ℂ, this may break badly. Here are some examples
Also, is it faster than |
This parser is not supposed to perform computations ; it should only accept inputs that are already just one complex number in full explicit form. |
after
versus before
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for working on this!
this is parsing in a simple way the string input for complex number constructor, avoiding usage of `sage_eval` there ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38391 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
this is parsing in a simple way the string input for complex number constructor, avoiding usage of `sage_eval` there ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38391 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
this is parsing in a simple way the string input for complex number constructor, avoiding usage of `sage_eval` there ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. URL: sagemath#38391 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
this is parsing in a simple way the string input for complex number constructor, avoiding usage of
sage_eval
there📝 Checklist