`sage.rings.padics`: Update `# needs` #36259

mkoeppe · 2023-09-12T23:51:30Z

Another update of # needs in sage.rings, with a focus on sage.rings.padics.

In #35095, the distributions sagemath-pari, sagemath-ntl, sagemath-flint, and sagemath-linbox now provide p-adic rings. The feature sage.rings.padics covers the common rings implemented using PARI and NTL. Additional rings are provided using FLINT.

Cherry-picked from #35095.

📝 Checklist

The title is concise, informative, and self-explanatory.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation accordingly.

⌛ Dependencies

…needs

…Add tags

…c/sage/rings

…t --distribution sagemath-ntl --distribution sagemath-pari --distribution sagemath-categories --only-tags --probe sage.rings.function_field src/sage/rings/padics src/sage/rings/valuation src/sage/rings/polynomial/padics

dcoudert

I have not yet checked this giant PR line by line. At least it passes all tests.

I see the following warnings

sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/function_field/function_field_rational.py
**********************************************************************
File "src/sage/rings/function_field/function_field_rational.py", line 140, in sage.rings.function_field.function_field_rational.RationalFunctionField.
__init__
Warning: Variable 'K' referenced here was set only in doctest marked '# needs sage.rings.real_mpfr'
    TestSuite(K).run()               # long time (5s)
    [158 tests, 3.60 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/infinity.py
**********************************************************************
File "src/sage/rings/infinity.py", line 946, in sage.rings.infinity.UnsignedInfinity._sympy_
Warning: Consider using a block-scoped tag by inserting the line 'sage: # needs sympy' just before this line to avoid repeating the tag 4 times
    import sympy                                                          # needs sympy
**********************************************************************
File "src/sage/rings/infinity.py", line 1629, in sage.rings.infinity.MinusInfinity._sympy_
Warning: Consider using a block-scoped tag by inserting the line 'sage: # needs sympy' just before this line to avoid repeating the tag 4 times
    import sympy                                                          # needs sympy
    [314 tests, 0.87 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/complex_double.pyx
**********************************************************************
File "src/sage/rings/complex_double.pyx", line 2554, in sage.rings.complex_double.ComplexToCDF
Warning: Consider using a block-scoped tag by inserting the line 'sage: # needs numpy' just before this line to avoid repeating the tag 4 times
    import numpy                                                              # needs numpy
    [338 tests, 0.21 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/function_field/function_field.py
**********************************************************************
File "src/sage/rings/function_field/function_field.py", line 128, in sage.rings.function_field.function_field
Warning: Variable 'K' referenced here was set only in doctest marked '# needs sage.rings.finite_rings'; '# needs sage.rings.function_field'; '# needs 
sage.rings.function_field sage.rings.number_field'
    TestSuite(K).run(max_runs=256)        # long time (10s)                       # needs sage.rings.number_field
    [293 tests, 64.57 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/integer.pyx
**********************************************************************
File "src/sage/rings/integer.pyx", line 3451, in sage.rings.integer.Integer.quo_rem
Warning: Consider using a block-scoped tag by inserting the line 'sage: # needs mpmath' just before this line to avoid repeating the tag 4 times
    import mpmath                                                         # needs mpmath
**********************************************************************
File "src/sage/rings/integer.pyx", line 6233, in sage.rings.integer.Integer.__array_interface__
Warning: Variable 'numpy' referenced here was set only in doctest marked '# needs numpy'
    numpy.array(2**40).dtype
**********************************************************************
File "src/sage/rings/integer.pyx", line 6235, in sage.rings.integer.Integer.__array_interface__
Warning: Variable 'numpy' referenced here was set only in doctest marked '# needs numpy'
    numpy.array(2**400).dtype
**********************************************************************
File "src/sage/rings/integer.pyx", line 6237, in sage.rings.integer.Integer.__array_interface__
Warning: Variable 'numpy' referenced here was set only in doctest marked '# needs numpy'
    numpy.array([1,2,3,0.1]).dtype
    [1186 tests, 34.60 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/local_generic.py
**********************************************************************
File "src/sage/rings/padics/local_generic.py", line 333, in sage.rings.padics.local_generic.LocalGeneric.change
Warning: Variable 'K' referenced here was set only in doctest marked '# needs sage.libs.flint sage.rings.padics'
    K.change(names='b')
**********************************************************************
File "src/sage/rings/padics/local_generic.py", line 338, in sage.rings.padics.local_generic.LocalGeneric.change
Warning: Variable 'K' referenced here was set only in doctest marked '# needs sage.libs.flint sage.rings.padics'
    Kup = K.change(prec=8); Kup
**********************************************************************
File "src/sage/rings/padics/local_generic.py", line 347, in sage.rings.padics.local_generic.LocalGeneric.change
Warning: Variable 'K' referenced here was set only in doctest marked '# needs sage.libs.flint sage.rings.padics'
    Kdown = K.change(prec=2); Kdown
    [240 tests, 0.50 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/padic_capped_absolute_element.pyx
**********************************************************************
File "src/sage/rings/padics/padic_capped_absolute_element.pyx", line 481, in sage.rings.padics.padic_capped_absolute_element.pAdicCappedAbsoluteElemen
t._exp_newton
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
**********************************************************************
File "src/sage/rings/padics/padic_capped_absolute_element.pyx", line 481, in sage.rings.padics.padic_capped_absolute_element.pAdicCappedAbsoluteElemen
t._exp_newton
Warning: Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
    [61 tests, 0.07 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/padic_capped_relative_element.pyx
**********************************************************************
File "src/sage/rings/padics/padic_capped_relative_element.pyx", line 539, in sage.rings.padics.padic_capped_relative_element.pAdicCappedRelativeElemen
t._exp_newton
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
**********************************************************************
File "src/sage/rings/padics/padic_capped_relative_element.pyx", line 539, in sage.rings.padics.padic_capped_relative_element.pAdicCappedRelativeElemen
t._exp_newton
Warning: Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
    [83 tests, 0.08 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/padic_fixed_mod_element.pyx
**********************************************************************
File "src/sage/rings/padics/padic_fixed_mod_element.pyx", line 546, in sage.rings.padics.padic_fixed_mod_element.pAdicFixedModElement._exp_newton
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
**********************************************************************
File "src/sage/rings/padics/padic_fixed_mod_element.pyx", line 546, in sage.rings.padics.padic_fixed_mod_element.pAdicFixedModElement._exp_newton
Warning: Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
    [66 tests, 0.07 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/padic_floating_point_element.pyx
**********************************************************************
File "src/sage/rings/padics/padic_floating_point_element.pyx", line 423, in sage.rings.padics.padic_floating_point_element.pAdicFloatingPointElement._
exp_newton
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
**********************************************************************
File "src/sage/rings/padics/padic_floating_point_element.pyx", line 423, in sage.rings.padics.padic_floating_point_element.pAdicFloatingPointElement._
exp_newton
Warning: Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.ntl'
    x = R(7*w)
    [62 tests, 0.07 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/padic_extension_leaves.py
**********************************************************************
File "src/sage/rings/padics/padic_extension_leaves.py", line 306, in sage.rings.padics.padic_extension_leaves.UnramifiedExtensionRingFixedMod
Warning: Variable 'R' referenced here was set only in doctest marked '# needs sage.libs.flint'
    TestSuite(R).run(skip='_test_log',max_runs=4) # long time
    [73 tests, 1.76 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/tutorial.py
**********************************************************************
File "src/sage/rings/padics/tutorial.py", line 335, in sage.rings.padics.tutorial
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.libs.ntl sage.rings.padics'
    (1 + w)^7                                                                     # needs sage.libs.ntl
    [45 tests, 0.12 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/padics/padic_generic_element.pyx
**********************************************************************
File "src/sage/rings/padics/padic_generic_element.pyx", line 2309, in sage.rings.padics.padic_generic_element.pAdicGenericElement._im_gens_
Warning: Variable 'ww' referenced here was set only in doctest marked '# needs sage.libs.ntl sage.symbolic'
    beta(ww*zz) == beta(ww)*beta(zz)
    [827 tests, 7.58 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/number_field/number_field.py
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1337, in sage.rings.number_field.number_field.NumberField_generic
Warning: Variable 'G' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.modular'
    for chi in G:             # long time
        D = ModularSymbols(chi, 2, -1).cuspidal_subspace().new_subspace().decomposition()
        for f in D:
            elt = f.q_eigenform(10, 'alpha')[3]
            assert elt.is_integral()
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1730, in sage.rings.number_field.number_field.NumberField_generic._element_constructor_
Warning: Variable 'QQi' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.symbolic'
    QQi(("1", "2"))
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1732, in sage.rings.number_field.number_field.NumberField_generic._element_constructor_
Warning: Variable 'QQi' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.symbolic'
    QQi((RR(1), RR(2)))
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1734, in sage.rings.number_field.number_field.NumberField_generic._element_constructor_
Warning: Variable 'QQi' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.symbolic'
    QQi(vector((RR(1), RR(2))))
    [2444 tests, 24.61 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/polynomial/hilbert.pyx
**********************************************************************
File "src/sage/rings/polynomial/hilbert.pyx", line 460, in sage.rings.polynomial.hilbert.first_hilbert_series
Warning: Variable 'first_hilbert_series' referenced here was set only in doctest marked '# needs sage.libs.singular'
    first_hilbert_series(I)
**********************************************************************
File "src/sage/rings/polynomial/hilbert.pyx", line 462, in sage.rings.polynomial.hilbert.first_hilbert_series
Warning: Variable 'first_hilbert_series' referenced here was set only in doctest marked '# needs sage.libs.singular'
    first_hilbert_series(singular(I))
**********************************************************************
File "src/sage/rings/polynomial/hilbert.pyx", line 465, in sage.rings.polynomial.hilbert.first_hilbert_series
Warning: Variable 'first_hilbert_series' referenced here was set only in doctest marked '# needs sage.libs.singular'
    first_hilbert_series(I)
**********************************************************************
File "src/sage/rings/polynomial/hilbert.pyx", line 467, in sage.rings.polynomial.hilbert.first_hilbert_series
Warning: Variable 'first_hilbert_series' referenced here was set only in doctest marked '# needs sage.libs.singular'
    first_hilbert_series(singular(I))
    [24 tests, 0.15 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/polynomial/multi_polynomial.pyx
**********************************************************************
File "src/sage/rings/polynomial/multi_polynomial.pyx", line 2732, in sage.rings.polynomial.multi_polynomial.MPolynomial.is_lorentzian
Warning: Variable 'z' referenced here was set only in doctest marked '# needs sage.rings.real_mpfr'
    q = z^2 + w^2
**********************************************************************
File "src/sage/rings/polynomial/multi_polynomial.pyx", line 2732, in sage.rings.polynomial.multi_polynomial.MPolynomial.is_lorentzian
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.rings.real_mpfr'
    q = z^2 + w^2
    [589 tests, 1.13 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/polynomial/polynomial_element.pyx
**********************************************************************
File "src/sage/rings/polynomial/polynomial_element.pyx", line 9205, in sage.rings.polynomial.polynomial_element.Polynomial.is_lorentzian
Warning: Variable 'y' referenced here was set only in doctest marked '# needs sage.rings.real_mpfr'
    q = y^2
    [2688 tests, 7.65 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/valuation/valuation.py
**********************************************************************
File "src/sage/rings/valuation/valuation.py", line 566, in sage.rings.valuation.valuation.DiscreteValuation.mac_lane_approximants
Warning: Variable 'v2' referenced here was set only in doctest marked '# needs sage.geometry.polyhedron'
    v1.phi() * v2.phi() - G                                               # needs sage.rings.padics
**********************************************************************
File "src/sage/rings/valuation/valuation.py", line 568, in sage.rings.valuation.valuation.DiscreteValuation.mac_lane_approximants
Warning: Variable 'w1' referenced here was set only in doctest marked '# needs sage.geometry.polyhedron'
    w1.phi() * w2.phi() - G                                               # needs sage.rings.padics
**********************************************************************
File "src/sage/rings/valuation/valuation.py", line 568, in sage.rings.valuation.valuation.DiscreteValuation.mac_lane_approximants
Warning: Variable 'w2' referenced here was set only in doctest marked '# needs sage.geometry.polyhedron'
    w1.phi() * w2.phi() - G                                               # needs sage.rings.padics
    [233 tests, 3.02 s]
sage -t --long --random-seed=339153682694300961491960201161141957323 src/sage/rings/valuation/augmented_valuation.py
**********************************************************************
File "src/sage/rings/valuation/augmented_valuation.py", line 286, in sage.rings.valuation.augmented_valuation.AugmentedValuation_base
Warning: Variable 'w' referenced here was set only in doctest marked '# needs sage.rings.number_field'
    TestSuite(w).run() # long time
**********************************************************************
File "src/sage/rings/valuation/augmented_valuation.py", line 287, in sage.rings.valuation.augmented_valuation.AugmentedValuation_base
Warning: Variable 'ww' referenced here was set only in doctest marked '# needs sage.rings.number_field'
    TestSuite(ww).run() # long time
    [489 tests, 15.51 s]

mkoeppe · 2023-11-03T18:29:58Z

Thank you! All fixed now, I think.

dcoudert · 2023-11-03T19:48:22Z

remaining doctests warnings

sage -t --long --random-seed=227857911659744001662371041055435503760 src/sage/rings/number_field/number_field.py
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1729, in sage.rings.number_field.number_field.NumberField_generic._element_constructor_
Warning: Variable 'QQi' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.symbolic'
    QQi(("1", "2"))
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1731, in sage.rings.number_field.number_field.NumberField_generic._element_constructor_
Warning: Variable 'QQi' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.symbolic'
    QQi((RR(1), RR(2)))
**********************************************************************
File "src/sage/rings/number_field/number_field.py", line 1733, in sage.rings.number_field.number_field.NumberField_generic._element_constructor_
Warning: Variable 'QQi' referenced here was set only in doctest marked '# needs sage.libs.linbox sage.symbolic'
    QQi(vector((RR(1), RR(2))))
    [2444 tests, 24.60 s]
sage -t --long --random-seed=227857911659744001662371041055435503760 src/sage/rings/integer.pyx
**********************************************************************
File "src/sage/rings/integer.pyx", line 6235, in sage.rings.integer.Integer.__array_interface__
Warning: Variable 'numpy' referenced here was set only in doctest marked '# needs numpy'
    numpy.array(2**40).dtype
**********************************************************************
File "src/sage/rings/integer.pyx", line 6237, in sage.rings.integer.Integer.__array_interface__
Warning: Variable 'numpy' referenced here was set only in doctest marked '# needs numpy'
    numpy.array(2**400).dtype
**********************************************************************
File "src/sage/rings/integer.pyx", line 6239, in sage.rings.integer.Integer.__array_interface__
Warning: Variable 'numpy' referenced here was set only in doctest marked '# needs numpy'
    numpy.array([1,2,3,0.1]).dtype
    [1186 tests, 33.52 s]

dcoudert · 2023-11-04T09:13:13Z

There is a failing doctest with Conda (macos-latest, 3.10, environnement) that might not be related to this PR. Please check.

sage -t --random-seed=216372951015555334120737541983419420334 src/sage/rings/polynomial/skew_polynomial_finite_field.pyx
**********************************************************************
File "src/sage/rings/polynomial/skew_polynomial_finite_field.pyx", line 1082, in sage.rings.polynomial.skew_polynomial_finite_field.SkewPolynomial_finite_field_dense.factorizations
Failed example:
    factorizations == factorizations2
Expected:
    False
Got:
    True
**********************************************************************
1 item had failures:
   1 of  15 in sage.rings.polynomial.skew_polynomial_finite_field.SkewPolynomial_finite_field_dense.factorizations
    [151 tests, 1 failure, 2.01 s]

dcoudert · 2023-11-04T10:01:31Z

There is a failing doctest with Conda (macos-latest, 3.10, environnement) that might not be related to this PR. Please check.

Actually, this is a random failure that has nothing to do with this PR. I observe it without this PR on Fedora. See #36646 and #36647.

dcoudert

some more issues

src/sage/rings/number_field/number_field_rel.py

src/sage/rings/padics/padic_ZZ_pX_element.pyx

dcoudert · 2023-11-04T11:19:24Z

src/sage/rings/padics/padic_generic_element.pyx

            sage: W.<w> = K.extension(f)
            sage: z = 1 - w^2 + O(w^11)
            sage: x = 1 - z
            sage: z.log().precision_absolute()
            -975
+


I don't understand why I don't see any warning for x. It is created in a block with # needs... and used in another block without # needs....

x is already unconditionally defined, from the global environment, so there won't be warnings

I'm removing the blank line.

src/sage/rings/padics/padic_generic_element.pyx

dcoudert · 2023-11-04T11:21:18Z

src/sage/rings/padics/pow_computer_ext.pyx

@@ -917,7 +918,7 @@ cdef class PowComputer_ZZ_pX(PowComputer_ext):
        EXAMPLES::

            sage: PC = PowComputer_ext_maker(5, 5, 10, 20, False, ntl.ZZ_pX([-5,0,1],5^10), 'FM', 'e',ntl.ZZ_pX([1],5^10))
-            sage: PC._restore_context_capdiv_test(8) #indirect doctest
+            sage: PC._restore_context_capdiv_test(8)  #indirect doctest


space after #

Done throughout sage.rings.padics in b28f626

src/sage/rings/padics/pow_computer_ext.pyx

src/sage/rings/valuation/augmented_valuation.py

…/#indirect doctest ?/# indirect doctest/'; git grep -l '# indirec' src/sage/rings/padics | xargs sed -E -i.bak 's/([^ ]) # indirect doctest ?/\1 # indirect doctest/'

…, doctest cosmetics

dcoudert · 2023-11-04T15:29:34Z

I'm unable to build the documentation (also reported by Lint)

[sagemath_doc_html-none] [valuation] The inventory files are in ../../local/share/doc/sage/inventory/en/reference/valuations.
[sagemath_doc_html-none] Error building the documentation.
[sagemath_doc_html-none] Traceback (most recent call last):
[sagemath_doc_html-none]   File "/usr/lib64/python3.10/runpy.py", line 196, in _run_module_as_main
[sagemath_doc_html-none]     return _run_code(code, main_globals, None,
[sagemath_doc_html-none]   File "/usr/lib64/python3.10/runpy.py", line 86, in _run_code
[sagemath_doc_html-none]     exec(code, run_globals)
[sagemath_doc_html-none]   File "/home/dcoudert/sage/pkgs/sage-docbuild/sage_docbuild/__main__.py", line 508, in <module>
[sagemath_doc_html-none]     sys.exit(main())
[sagemath_doc_html-none]   File "/home/dcoudert/sage/pkgs/sage-docbuild/sage_docbuild/__main__.py", line 504, in main
[sagemath_doc_html-none]     builder()
[sagemath_doc_html-none]   File "/home/dcoudert/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 818, in _wrapper
[sagemath_doc_html-none]     getattr(DocBuilder, build_type)(self, *args, **kwds)
[sagemath_doc_html-none]   File "/home/dcoudert/sage/pkgs/sage-docbuild/sage_docbuild/builders.py", line 162, in f
[sagemath_doc_html-none]     runsphinx()
[sagemath_doc_html-none]   File "/home/dcoudert/sage/pkgs/sage-docbuild/sage_docbuild/sphinxbuild.py", line 327, in runsphinx
[sagemath_doc_html-none]     sys.stderr.raise_errors()
[sagemath_doc_html-none]   File "/home/dcoudert/sage/pkgs/sage-docbuild/sage_docbuild/sphinxbuild.py", line 263, in raise_errors
[sagemath_doc_html-none]     raise OSError(self._error)
[sagemath_doc_html-none] OSError: /home/dcoudert/sage/src/sage/rings/valuation/augmented_valuation.py:docstring of sage.rings.valuation.augmented_valuation.FiniteAugmentedValuation.simplify:58: ERROR: Unexpected indentation.
[sagemath_doc_html-none] 
[sagemath_doc_html-none]     Note: incremental documentation builds sometimes cause spurious
[sagemath_doc_html-none]     error messages. To be certain that these are real errors, run
[sagemath_doc_html-none]     "make doc-clean doc-uninstall" first and try again.

…er in docstring

github-actions · 2023-11-04T17:09:54Z

Documentation preview for this PR (built with commit 5e4ea11; changes) is ready! 🎉

dcoudert

Finally, LGTM.

mkoeppe · 2023-11-04T22:42:04Z

Thanks very much!

mkoeppe added c: padics t: refactoring labels Sep 12, 2023

mkoeppe self-assigned this Sep 12, 2023

mkoeppe added the s: needs review label Sep 14, 2023

Matthias Koeppe added 26 commits September 16, 2023 11:33

src/sage/rings/number_field/galois_group.py: Add file level # needs

f76c2cd

sage.rings.number_field: Update # needs

682b174

src/sage/rings/universal_cyclotomic_field.py: Update distribution, # …

b25e987

…needs

src/sage/algebras: Add file-level tags; src/sage/rings/finite_rings: …

7a65270

…Add tags

./sage -fixdoctests --distribution sagemath-categories --only-tags sr…

9ead00b

…c/sage/rings

sage.rings: Block tags, update # needs

be756b6

sage.rings: More block tags, update # needs

14990f0

sage.rings: Update # needs

571b0f7

src/sage/rings/polynomial/polynomial_element.pyx: Update # needs

36f7707

Fix # needs for sagemath-pari

35c2232

sage.rings: Update # needs

d7cf4a7

sage.rings: Update # needs

5ffeedf

src/sage/rings/number_field/number_field.py: Use lazy_import

e91b7c6

sage.rings: Update # needs

ae8b9b2

src/sage/rings/real_arb.pyx: Update # needs

c719121

Add # needs

7e08b6f

sage.rings: Update # needs

bfd4c03

sage.rings: Update # needs

ee95b2a

sage.rings: Update # needs

94a8772

sage.rings.polynomial: Update # needs

962347d

sage.rings.number_field: Update # needs

fb7fbab

sage.rings.padics: Fix up import, update # needs

e2fcede

sage.rings: Update # needs

bb87f79

sage.rings.{padics,valuation}: Update # needs

613b069

sage.rings: Update # needs

85e8033

mkoeppe requested a review from dcoudert October 30, 2023 19:30

Merge branch 'develop' into needs_for_sage_rings_padics

c5f0b67

dcoudert suggested changes Nov 3, 2023

View reviewed changes

Matthias Koeppe added 6 commits November 3, 2023 11:08

sage.rings: More block tags, fix tags

754eff4

sage.rings.function_field: More block tags, fix tags

0f5b767

sage.rings.padics: More block tags, fix tags

7053a64

sage.rings.number_field: More block tags, fix tags

45b833b

sage.rings.polynomial: More block tags, fix tags

73e41c6

sage.rings.valuation: More block tags, fix tags, doctest cosmetics

473f84d

sage.rings: Fix remaining doctests warnings

7b88728

dcoudert suggested changes Nov 4, 2023

View reviewed changes

Matthias Koeppe added 5 commits November 4, 2023 06:22

src/sage/rings/number_field/number_field_rel.py: Use more block tags

37e66cb

src/sage/rings/padics/padic_ZZ_pX_element.pyx: Use more block tags

a1bdea9

src/sage/rings/padics/padic_generic_element.pyx: Use more block tags

a1f134f

git grep -l '#indirec' src/sage/rings/padics | xargs sed -E -i.bak 's…

b28f626

…/#indirect doctest ?/# indirect doctest/'; git grep -l '# indirec' src/sage/rings/padics | xargs sed -E -i.bak 's/([^ ]) # indirect doctest ?/\1 # indirect doctest/'

src/sage/rings/valuation/augmented_valuation.py: Remove redundant tag…

957f80d

…, doctest cosmetics

src/sage/rings/valuation/augmented_valuation.py: Remove stray charact…

5e4ea11

…er in docstring

dcoudert approved these changes Nov 4, 2023

View reviewed changes

dcoudert added s: positive review and removed s: needs review labels Nov 4, 2023

vbraun merged commit 3de6e29 into sagemath:develop Nov 5, 2023

github-actions bot removed the s: positive review label Nov 5, 2023

mkoeppe added this to the sage-10.2 milestone Nov 5, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`sage.rings.padics`: Update `# needs` #36259

`sage.rings.padics`: Update `# needs` #36259

mkoeppe commented Sep 12, 2023 •

edited

Loading

dcoudert left a comment

mkoeppe commented Nov 3, 2023

dcoudert commented Nov 3, 2023

dcoudert commented Nov 4, 2023

dcoudert commented Nov 4, 2023

dcoudert left a comment

dcoudert Nov 4, 2023

mkoeppe Nov 4, 2023

dcoudert Nov 4, 2023

mkoeppe Nov 4, 2023 •

edited

Loading

dcoudert commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

dcoudert left a comment

mkoeppe commented Nov 4, 2023

sage.rings.padics: Update # needs #36259

sage.rings.padics: Update # needs #36259

Conversation

mkoeppe commented Sep 12, 2023 • edited Loading

📝 Checklist

⌛ Dependencies

dcoudert left a comment

Choose a reason for hiding this comment

mkoeppe commented Nov 3, 2023

dcoudert commented Nov 3, 2023

dcoudert commented Nov 4, 2023

dcoudert commented Nov 4, 2023

dcoudert left a comment

Choose a reason for hiding this comment

dcoudert Nov 4, 2023

Choose a reason for hiding this comment

mkoeppe Nov 4, 2023

Choose a reason for hiding this comment

dcoudert Nov 4, 2023

Choose a reason for hiding this comment

mkoeppe Nov 4, 2023 • edited Loading

Choose a reason for hiding this comment

dcoudert commented Nov 4, 2023

github-actions bot commented Nov 4, 2023

dcoudert left a comment

Choose a reason for hiding this comment

mkoeppe commented Nov 4, 2023

`sage.rings.padics`: Update `# needs` #36259

`sage.rings.padics`: Update `# needs` #36259

mkoeppe commented Sep 12, 2023 •

edited

Loading

mkoeppe Nov 4, 2023 •

edited

Loading