Implement twisted affine Lie algebras #35591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…vements. - Brings coverage up to 100% in lie_algebras. - Faster Killing matrix for Chevalley basis (which speeds up untwisted affine brackets). - Fix bug in creating the affine type from a finite type.
|
linter not happy and doctest failing |
… with less readability.
tscrim
force-pushed
the
lie_algebras/twisted_affine
branch
from
a4198ba
to
f50a218
Compare
|
This should make it pass the tests; I forgot to add in the output. I also fixed the docbuild issue (although shortening a 3 letter name to 2 letters for a reference is a bit strange to me...). I also did the changes the linter is requiring, but IMO it makes the code less readable (I really don't see any utility of that blankline before nested definitions and only to those (not, e.g., for |
|
There are still some |
tscrim
force-pushed
the
lie_algebras/twisted_affine
branch
from
a3798ed
to
27593ea
Compare
|
Right, sorry about that. I didn't grep carefully enough. |
|
Documentation preview for this PR (built with commit fd069d7) is ready! 🎉 |
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Description
Untwisted affine Lie algebras have been implemented in Sage for some time, but their twisted counterparts have been missing. They are more complicated to implement due to the involvement of a diagram automorphism, third roots of unity, and nonreduced root systems.
Along the way, I made some additional fixes in regards to this enhancement:
📝 Checklist
⌛ Dependencies