Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slight generalisation of MZV auxiliary F-algebra #35420

Merged

Conversation

fchapoton
Copy link
Contributor

by allowing to start the odd indices at 1 or 3

📚 Description

The auxiliary F-algebra for Multiple Zeta Values is slightly generalised : its odd indices can start at 1 or 3.

This is motivated by the case of alternating MZV.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few little things.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Two more of the same doc change and one additional doc tweak.

Comment on lines 14 to 15
The similar algebra on generators `f_1`, `f_3`, `f_5`, ... and `f_2`
is now also available.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The similar algebra on generators `f_1`, `f_3`, `f_5`, ... and `f_2`
is now also available.
The similar algebra with generators a subset of
`f_1`, `f_3`, `f_5`, `\ldots` and `f_2` is now also available.

Perhaps this is closer to what you mean? The current addition makes it seem like it is just the same algebra as it is generated by the same set (unless I am missing something).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, but I wrote something vague, for sure. There is a base ring which remains a polynomial in f_2, over which one has a shuffle algebra in one more generator f_1, in addition to the generators f_3, f_5, etc. Should I reformulate ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, the code is saying something slightly different: you want to consider the algebras that have $f_2$ and $f_i, f_{i+2}, \ldots$ for some odd integer $i$. Of course, this includes $i = 1$ as per the ticket description, but I guess there is a slight mismatch between your intent and implementation? Perhaps it would be better to rename start (at least for the algebra input) to extended or some other boolean input to match this documentation?

@fchapoton fchapoton force-pushed the slight_generalisation_of_MZV_F_algebra branch from 976029d to d9edc52 Compare April 5, 2023 06:46
@fchapoton
Copy link
Contributor Author

ok, I have reformulated the doc so that any odd start index is allowed. Of course, only the start indices 1 and 3 are useful, but the implementation does not see any difference. One could even allow arbitrary subsets of odd integers, but this would just be re-doing the general implementation of shuffle algebras.

Copy link
Collaborator

@tscrim tscrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. I have just made one more suggested micro-optimization if you want to include it. Once done or ignored, you can mark this as a positive review.

micro-optimisation

Co-authored-by: Travis Scrimshaw <[email protected]>
@fchapoton
Copy link
Contributor Author

thanks a lot, Travis. I am setting to positive

@tscrim
Copy link
Collaborator

tscrim commented Apr 7, 2023

No problem.

@github-actions
Copy link

github-actions bot commented Apr 7, 2023

Documentation preview for this PR is ready! 🎉
Built with commit: 81748fb

@vbraun vbraun merged commit 5aee21c into sagemath:develop Apr 13, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Apr 14, 2023
@fchapoton fchapoton deleted the slight_generalisation_of_MZV_F_algebra branch July 16, 2023 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants