-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Matplotlib 3.7.0 support #35177
Matplotlib 3.7.0 support #35177
Conversation
Codecov ReportBase: 88.60% // Head: 88.59% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #35177 +/- ##
===========================================
- Coverage 88.60% 88.59% -0.02%
===========================================
Files 2140 2140
Lines 397273 397273
===========================================
- Hits 352004 351958 -46
- Misses 45269 45315 +46
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, my suggestion is of style. Your choice, in any case let's get this merged soon.
I think it is all very good feedback. I only did the minimum job suggested by the warnings. I will adopt it ASAP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with the system matplotlib 3.7.0 and 3.6.3 on void linux.
Thanks! |
Just merged to update to latest beta. No issues that need a new review. |
Documentation preview for this PR is ready! 🎉 |
📚 Description
Matplotlib 3.7.0 introduce some changes to the labelling of objects in subplots (mainly "subplot" is gone). This PR fixes the affected doctests.
There are also some deprecations warnings that can be dealt with by using objects already available in matplotlib 3.6.
Finally one user warning has gone away.
📝 Checklist