Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matplotlib 3.7.0 support #35177

Merged
merged 6 commits into from
Mar 26, 2023
Merged

Matplotlib 3.7.0 support #35177

merged 6 commits into from
Mar 26, 2023

Conversation

kiwifb
Copy link
Member

@kiwifb kiwifb commented Feb 23, 2023

📚 Description

Matplotlib 3.7.0 introduce some changes to the labelling of objects in subplots (mainly "subplot" is gone). This PR fixes the affected doctests.
There are also some deprecations warnings that can be dealt with by using objects already available in matplotlib 3.6.
Finally one user warning has gone away.

📝 Checklist

  • [*] I have made sure that the title is self-explanatory and the description concisely explains the PR.
  • I have linked an issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023

Codecov Report

Base: 88.60% // Head: 88.59% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (577b9ca) compared to base (8f5bbd2).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #35177      +/-   ##
===========================================
- Coverage    88.60%   88.59%   -0.02%     
===========================================
  Files         2140     2140              
  Lines       397273   397273              
===========================================
- Hits        352004   351958      -46     
- Misses       45269    45315      +46     
Impacted Files Coverage Δ
src/sage/plot/contour_plot.py 92.23% <ø> (ø)
src/sage/plot/graphics.py 87.44% <ø> (ø)
src/sage/plot/multigraphics.py 85.20% <ø> (ø)
src/sage/plot/plot3d/plot_field3d.py 100.00% <100.00%> (ø)
src/sage/crypto/util.py 91.37% <0.00%> (-5.18%) ⬇️
src/sage/interfaces/qsieve.py 71.30% <0.00%> (-2.61%) ⬇️
src/sage/combinat/combination.py 93.50% <0.00%> (-1.50%) ⬇️
src/sage/combinat/posets/poset_examples.py 87.67% <0.00%> (-1.01%) ⬇️
src/sage/coding/channel.py 97.10% <0.00%> (-0.73%) ⬇️
...sage/geometry/hyperbolic_space/hyperbolic_model.py 88.95% <0.00%> (-0.62%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tornaria tornaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, my suggestion is of style. Your choice, in any case let's get this merged soon.

@kiwifb
Copy link
Member Author

kiwifb commented Feb 23, 2023

I think it is all very good feedback. I only did the minimum job suggested by the warnings. I will adopt it ASAP.

Copy link
Contributor

@tornaria tornaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with the system matplotlib 3.7.0 and 3.6.3 on void linux.

@kiwifb
Copy link
Member Author

kiwifb commented Feb 24, 2023

Thanks!

@kiwifb
Copy link
Member Author

kiwifb commented Feb 24, 2023

Just merged to update to latest beta. No issues that need a new review.

@kiwifb kiwifb removed the request for review from antonio-rojas February 24, 2023 01:15
@github-actions
Copy link

Documentation preview for this PR is ready! 🎉
Built with commit: 577b9ca

@vbraun vbraun merged commit 002b464 into sagemath:develop Mar 26, 2023
@mkoeppe mkoeppe added this to the sage-10.0 milestone Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants