Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cygwin: ratpoints is broken again #8267

Closed
williamstein opened this issue Feb 15, 2010 · 7 comments
Closed

cygwin: ratpoints is broken again #8267

williamstein opened this issue Feb 15, 2010 · 7 comments

Comments

@williamstein
Copy link
Contributor

I just tried building the ratpoints package on Cygwin, and

gcc main.c -o ratpoints -I/home/wstein/build/sage-4.3.3.alpha0/local/include -Wall -O2 -fPIC -DRATPOINTS_MAX_BITS_IN_PRIME=7 -DUSE_SSE -L/home/wstein/build/sage-4.3.3.alpha0/local/lib -lgmp -lm -L. -lratpoints                                     
main.c:1: warning: -fPIC ignored for target (all code is position independent)                                             
./libratpoints.a(find_points.o):find_points.c:(.text+0x170): undefined reference to `__imp____gmpz_mul_si' 
BOOM!

Thus the fixed that got in from #7015 has been broken before it ever really got to live :-(.

So this ticket is to implement that fix again.

Component: porting: Cygwin

Author: William Stein

Reviewer: Minh Van Nguyen

Merged: sage-4.3.3.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/8267

@williamstein
Copy link
Contributor Author

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 15, 2010

comment:2

Here are a few changes to William's spkg:

  • I renamed it to ratpoints-2.1.3.p0, which is the patch level that comes after ratpoints-2.1.3.
  • Turned on the executable bits of spkg-install.
  • Separate the changelog for ratpoints-2.1.3.p0 and ratpoints-2.1.3. The changelog now reads:
=== ratpoints-2.1.3.p0 (William Stein, 14 Feb 2010) ===
 * Include change to spkg-install so that build works on Cygwin,
   a fix that was in (trac #7015), and somehow got list.  See
   trac #8267.

=== ratpoints-2.1.3 (William Stein, 14 Feb 2010) ===
 * Evidently somebody updated ratpoints to 2.1.3 and didn't
   update the SPKG.txt.  Oops.

An updated spkg with the above changes is available at

http://sage.math.washington.edu/home/mvngu/spkg/standard/ratpoint/ratpoints-2.1.3.p0.spkg

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 16, 2010

comment:3

The package ratpoints-2.1.3.p0.spkg includes some cosmetic changes on top of William's spkg. Building ratpoints-2.1.3.p0.spkg went OK on Cygwin (winxp1 on boxen.math).

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 16, 2010

Reviewer: Minh Van Nguyen

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 16, 2010

Author: William Stein

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 16, 2010

Merged: sage-4.3.3.alpha1

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Feb 16, 2010

comment:4

Merged in the standard spkg repository.

@sagetrac-mvngu sagetrac-mvngu mannequin closed this as completed Feb 16, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant