Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cygwin port -- ratpoints -- don't build executable since we don't need it (and fails on cygwin) #7015

Closed
williamstein opened this issue Sep 25, 2009 · 7 comments

Comments

@williamstein
Copy link
Contributor

the ratpoints spkg builds an executable we just throw away. On Cygwin it fails though changing the link order from

	    -lgmp -lm -lratpoints
	to
	    -lm -lratpoints -lgmp

would fix the problem.

Component: packages: standard

Author: William Stein, Minh Van Nguyen

Reviewer: Mike Hansen

Merged: sage-4.2.alpha0

Issue created by migration from https://trac.sagemath.org/ticket/7015

@williamstein
Copy link
Contributor Author

@certik
Copy link
Contributor

certik commented Sep 25, 2009

comment:2

The only change in the spkg package is:

-make
+make libratpoints.a

since this is all that is needed, it's +1 from me.

@sagetrac-mvngu
Copy link
Mannequin

sagetrac-mvngu mannequin commented Sep 28, 2009

comment:3

Here's an updated spkg

http://sage.math.washington.edu/home/mvngu/release/spkg/standard/ratpoints-2.1.2.p4.spkg

Changes from William's version include:

  • Remove the junk files spkg-install~ and SPKG.txt~.
  • Make spkg-install executable using "chmod +x spkg-install".
  • Use about 75 characters for each line in the file SPKG.txt. Any longer than that and it would be difficult to read on a standard terminal width, i.e. 80 characters wide.

@mwhansen
Copy link
Contributor

comment:4

Looks good to me. I included the changes that Minh made to William's spkg and left the version at p3.

@mwhansen
Copy link
Contributor

Author: William Stein, Minh Van Nguyen

@mwhansen
Copy link
Contributor

Merged: sage-4.2.alpha0

@mwhansen
Copy link
Contributor

Reviewer: Mike Hansen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants