-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto browser open of notebook does not open to a valid url when interface="" #5675
Comments
comment:1
This ticket subsumes #5263. |
comment:2
There is socket.getfqdn, but does it help? On sage: import socket
sage: socket.getfqdn()
'localhost'
sage: socket.gethostbyname_ex(socket.gethostname())
('localhost', ['boxen', 'boxen'], ['127.0.0.1', '128.208.160.197']) On a local Linux machine, I get sage: import socket
sage: socket.getfqdn()
'localhost.localdomain'
sage: socket.gethostbyname_ex(socket.gethostname())
('localhost.localdomain', ['localhost', 'foo'], ['127.0.0.1']) all of which happen to be in What if we just add an option |
This comment has been minimized.
This comment has been minimized.
comment:3
Renaming this to a more appropriate title. |
Attachment: trac_5675-address-launch.patch.gz This sets the hostname to localhost if interface="" when launching the page |
Author: Tim Dumol |
comment:4
This fixes the issue described. |
comment:5
LGTM. See #5263. This bug is only for a blank option passed to |
Reviewer: Alex Leone |
comment:6
I see a few cases:
See #5263 for the publish url bug. |
Merged: sagenb-0.7 |
It used to be in the notebook that address="" was an error. Then when we switched to twisted, it suddenly meant "listen on all interfaces". Now it's a common option to give.
CC: @sagetrac-acleone
Component: notebook
Author: Tim Dumol
Reviewer: Alex Leone
Merged: sagenb-0.7
Issue created by migration from https://trac.sagemath.org/ticket/5675
The text was updated successfully, but these errors were encountered: