publishing a worksheet displays the URL without the hostname

[jasongrout]

When I publish a worksheet on sagenb.org, it says I can find the sheet at: http://:8000/home/pub/243

Of course, this is silly nonsense.

It might have to do with starting the notebook with address='', maybe?

CC: @kcrisman @williamstein @qed777

Component: notebook

Author: Tim Dumol

Reviewer: Mitesh Patel

Merged: sagenb-0.7

Issue created by migration from https://trac.sagemath.org/ticket/5263

[TimothyClemans]

comment:1

Yes it does use address. I just discovered that on my computer if I set address='sagenb.org' then I can't start the notebook.

[qed777]

comment:2

#5675 appears to be a duplicate, but with wider scope.

[jasongrout]

comment:3

I agree that this will probably be closed when #5675 is closed. I think that when #5675 is closed, this ought to be checked, and then closed if everything works.

[sagetrac-drkirkby]

comment:4

It looks like this has been a long standing bug, which nobody has worked on. I would make two suggestion, though.

Firstly, if this gets fixed, it would be sensible to detect the following range of IP addresses, and indicate they can not be routed over the internet.

• 10.x.x.x
• 172.16.x.x to 172.31.x.x
• 192.168.x.x

Secondly, perhaps a further reminder about the security risks would not go amiss either.

Dave

[qed777]

comment:6

Following the suggestions here and here, I get:

sage: import socket
sage: socket.gethostbyname(socket.gethostname())
'127.0.0.1'
sage: s = socket.socket(socket.AF_INET, socket.SOCK_DGRAM)
sage: s.connect(('google.com', 0))
sage: s.getsockname()[0]
'192.168.x.y'
sage: import urllib
sage: urllib.urlopen('http://whatismyip.org').read()
'a.b.c.d'

I'm looking now for ways to iterate over the available interfaces in Twisted...

By the way, there are a few suggestions to the main problem at #5675.

What is a good name for a keyword option that's inserted instead of the interface (post-#7639, address is deprecated) when interface=''?

[qed777]

comment:7

Replying to @qed777:

I'm looking now for ways to iterate over the available interfaces in Twisted...

I think Twisted just uses socket, which
uses the underlying system's socket library. I don't know if there is a local, cross-platform way to iterate over '0.0.0.0' (all interfaces) and map each to an IP address.

[TimDumol]

comment:8

I think using the HTTP-HOST header will be easier and more reliable. Here's a patch implementing that. Feel free to comment.

[TimDumol]

Uses the HTTP-HOST header to attempt to get the host name.

[qed777]

Author: Tim Dumol

[qed777]

comment:9

Attachment: trac_5263-publish-url.patch.gz

Nice!

[qed777]

Reviewer: Mitesh Patel

[qed777]

Merged: sagenb-0.7