Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find all the minimal separators of a graph #37743

Closed
1 task done
sanskarfc opened this issue Apr 4, 2024 · 4 comments · Fixed by #39341
Closed
1 task done

Find all the minimal separators of a graph #37743

sanskarfc opened this issue Apr 4, 2024 · 4 comments · Fixed by #39341
Labels
c: graph theory t: enhancement

Comments

@sanskarfc
Copy link

sanskarfc commented Apr 4, 2024 •
edited
Loading

Problem Description

Implement a function to find the list of all the minimal separators of a graph based on Berry's algorithm.

Proposed Solution

Implement the algorithm from this paper for finding all the minimal separators of a graph: https://doi.org/10.1007/3-540-46784-X_17

Alternatives Considered

Some other alternatives were considered, but the most useful use case at the time was to find all the minimal separators in one go for which, Berry's algorithm seemed fit.

Additional Information

No response

Is there an existing issue for this?

  • I have searched the existing issues for a bug report that matches the one I want to file, without success.
@dcoudert
Copy link
Contributor

dcoudert commented Apr 4, 2024

This is certainly a good idea to add a method for generating these separators.

@sanskarfc
Copy link
Author

Great! I already have the algorithm written down. I will add a PR asap and link it here.

@sanskarfc
Copy link
Author

@dcoudert Where do you think I should add this function for the PR? The algorithm can be found on this gist.

@dcoudert
Copy link
Contributor

may be in file src/sage/graphs/connectivity.pyx

@dcoudert dcoudert mentioned this issue Jan 18, 2025
Merged
5 tasks
vbraun pushed a commit to vbraun/sage that referenced this issue Jan 23, 2025
sagemathgh-39341: add an iterator over the minimal separators of a graph
2ae226d 
    
Fixes sagemath#37743.

Adds an iterator over the minimal separators of an undirected graphs.

We also fix the behavior of some methods using parameter
`forbidden_vertices` (added in sagemath#39151) when the input is an iterator.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39341
Reported by: David Coudert
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this issue Jan 25, 2025
sagemathgh-39341: add an iterator over the minimal separators of a graph
5ec8c38 
    
Fixes sagemath#37743.

Adds an iterator over the minimal separators of an undirected graphs.

We also fix the behavior of some methods using parameter
`forbidden_vertices` (added in sagemath#39151) when the input is an iterator.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39341
Reported by: David Coudert
Reviewer(s): Dima Pasechnik
vbraun pushed a commit to vbraun/sage that referenced this issue Jan 26, 2025
sagemathgh-39341: add an iterator over the minimal separators of a graph
17bc2c3 
    
Fixes sagemath#37743.

Adds an iterator over the minimal separators of an undirected graphs.

We also fix the behavior of some methods using parameter
`forbidden_vertices` (added in sagemath#39151) when the input is an iterator.


### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#39341
Reported by: David Coudert
Reviewer(s): Dima Pasechnik
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory t: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add an iterator over the minimal separators of a graph dcoudert/sage
2 participants
@dcoudert @sanskarfc