Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages #34957

Closed
mkoeppe opened this issue Jan 30, 2023 · 9 comments · Fixed by #35107
Closed

sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages #34957

mkoeppe opened this issue Jan 30, 2023 · 9 comments · Fixed by #35107
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-10.0

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 30, 2023 •
edited
Loading

Part of meta-ticket #34201

CC: @alexchandler100

Component: refactoring

Author: Alex Chandler

Issue created by migration from https://trac.sagemath.org/ticket/34957
@mkoeppe mkoeppe added this to the sage-9.8 milestone Jan 30, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Branch: u/mkoeppe/sage__finance_interacts_libs_numerical_statistics_tests___replace_imports_from_sage___all_for_namespace_packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

New commits:

1e88c12sage -fiximports src/sage/{finance,interacts,libs,numerical,statistics,tests}
572896dsrc/sage/{numerical,tests}: Manual fixes to imports

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023

Commit: 572896d

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from 572896d to 965dfc6

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

965dfc6sage -fiximports src/sage/stats

@mkoeppe mkoeppe changed the title sage.{finance,interacts,libs,numerical,statistics,tests}: Replace imports from sage.*.all for namespace packages sage.{finance,interacts,libs,numerical,stats,tests}: Replace imports from sage.*.all for namespace packages Jan 30, 2023
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Branch pushed to git repo; I updated commit sha1. New commits:

21b94basrc/sage/libs/giac/auto-methods.pxi: Back out whitespace changes in this autogenerated file

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 30, 2023

Changed commit from 965dfc6 to 21b94ba

@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 30, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 30, 2023 •
edited
Loading

comment:7

This was tested before the migration in https://github.com/sagemath/sagetrac-mirror/actions/runs/4039609960/jobs/6944514787
The doctest failure in sage/schemes/elliptic_curves/ell_number_field.py is unrelated (it's #34959)

mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#34957
a21254a
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2023

Removed branch from issue description; replaced by PR #35107

vbraun pushed a commit that referenced this issue Mar 19, 2023
gh-35107: sage.{finance,interacts,libs,numerical,stats,tests}: Replac…
49c2cd3 
…e imports from sage.*.all for namespace packages

<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes #1234" use "Introduce new method to
calculate 1+1"
-->
### 📚 Description
Fixes #34957

<!-- Describe your changes here in detail -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If it resolves an open issue, please link to the issue here. For
example "Closes #1337" -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->

- [x] I have made sure that the title is self-explanatory and the
description concisely explains the PR.
- [x] I have linked an issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies
<!-- List all open pull requests that this PR logically depends on -->
<!--
- #xyz: short description why this is a dependency
- #abc: ...
-->

URL: #35107
Reported by: Matthias Köppe
Reviewer(s): Dima Pasechnik, Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-10.0
1 participant
@mkoeppe