Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the import of some element classes in sage/ring/all.py #33602

Closed
DavidAyotte opened this issue Mar 30, 2022 · 14 comments
Closed

Deprecate the import of some element classes in sage/ring/all.py #33602

DavidAyotte opened this issue Mar 30, 2022 · 14 comments

Comments

@DavidAyotte
Copy link
Member

This tickets aims to remove some element classes from the global namespace. Example:

sage: PowerSeries?
Docstring:
   A power series. Base class of univariate and multivariate power
   series. The following methods are available with both types of
   objects.
Init docstring:
   Initialize a power series. Not for public use. It gets called by
   the "PowerSeries_poly" and "MPowerSeries" constructors.
[...]

CC: @tscrim

Component: refactoring

Author: David Ayotte

Branch/Commit: 10be916

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/33602

@DavidAyotte
Copy link
Member Author

Branch: u/gh-DavidAyotte/power_series

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2022

Commit: 01609e7

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

01609e7src/sage/rings/all.py: fix doctests output

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

5deb7c5src/sage/rings/all.py: fix typo

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2022

Changed commit from 01609e7 to 5deb7c5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

2818c1bFix failing doctests

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 30, 2022

Changed commit from 5deb7c5 to 2818c1b

@DavidAyotte
Copy link
Member Author

comment:6

I fixed the two failing doctests in sage/rings/laurent_series_ring_element.pyx and sage/rings/power_series_ring_element.pyx however I don't think that the failed doctest in sage/interfaces/expect.py is related to this ticket.

@tscrim
Copy link
Collaborator

tscrim commented Mar 31, 2022

comment:7

That test from #23928 is not right. The parent is wrong for instance. I think we should correct it by

-             sage: R.<x> = PowerSeriesRing(QQ, implementation='pari')
-             sage: f = LaurentSeries(R, x).add_bigoh(7)
+             sage: R.<x> = LaurentSeriesRing(QQ, implementation='pari')
+             sage: f = x.add_bigoh(7)
              sage: f(x)

Everything else LGTM.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2022

Changed commit from 2818c1b to 10be916

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 31, 2022

Branch pushed to git repo; I updated commit sha1. New commits:

10be916src/sage/rings/laurent_series_ring_element.pyx: fix an incorrect doctest

@tscrim
Copy link
Collaborator

tscrim commented Mar 31, 2022

comment:9

Thank you.

@tscrim
Copy link
Collaborator

tscrim commented Mar 31, 2022

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Apr 2, 2022

Changed branch from u/gh-DavidAyotte/power_series to 10be916

@vbraun vbraun closed this as completed in 7616759 Apr 2, 2022
mkoeppe added a commit to mkoeppe/sage that referenced this issue Sep 21, 2023
vbraun pushed a commit to vbraun/sage that referenced this issue Sep 23, 2023
, sagemath#24483, sagemath#24371, sagemath#24511, sagemath#25848, sagemath#26105, sagemath#28481, sagemath#29010, sagemath#29412, sagemath#30332, sagemath#30372, sagemath#31345, sagemath#32375, sagemath#32606, sagemath#32610, sagemath#32612, sagemath#32641, sagemath#32660, sagemath#32750, sagemath#32869, sagemath#33602

    
<!-- ^^^^^
Please provide a concise, informative and self-explanatory title.
Don't put issue numbers in there, do this in the PR body below.
For example, instead of "Fixes sagemath#1234" use "Introduce new method to
calculate 1+1"
-->
<!-- Describe your changes here in detail -->

<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes sagemath#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->
<!-- If your change requires a documentation PR, please link it
appropriately -->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
<!-- Feel free to remove irrelevant items. -->

- [x] The title is concise, informative, and self-explanatory.
- [ ] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- sagemath#12345: short description why this is a dependency
- sagemath#34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: sagemath#36307
Reported by: Matthias Köppe
Reviewer(s):
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants