Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parent._is_numerical, _is_real_numerical - remove hard dependency on real_mpfr, complex_mpfr #32625

Closed
mkoeppe opened this issue Oct 4, 2021 · 9 comments
Closed

Parent._is_numerical, _is_real_numerical - remove hard dependency on real_mpfr, complex_mpfr #32625

mkoeppe opened this issue Oct 4, 2021 · 9 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 4, 2021

This is for sagemath-polyhedra (#32432), which does not include the floating point fields

CC: @videlec @mezzarobba @tscrim @mjungmath

Component: refactoring

Author: Matthias Koeppe

Branch/Commit: bf0ed1d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/32625
@mkoeppe mkoeppe added this to the sage-9.5 milestone Oct 4, 2021
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Branch: u/mkoeppe/parent__is_numerical___is_real_numerical___remove_hard_dependency_on_real_mpfr__complex_mpfr

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

Commit: bf0ed1d

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 26, 2021

New commits:

bf0ed1d_is_[real_]numerical: Fall back to using CDF/RDF if ComplexField, RealField cannot be imported

@tscrim
Copy link
Collaborator

tscrim commented Oct 26, 2021

comment:5

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Oct 26, 2021

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 27, 2021

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Oct 31, 2021

Changed branch from u/mkoeppe/parent__is_numerical___is_real_numerical___remove_hard_dependency_on_real_mpfr__complex_mpfr to bf0ed1d

@vbraun vbraun closed this as completed in e3c14c2 Oct 31, 2021
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32625
7324f91
mkoeppe added a commit to mkoeppe/sage that referenced this issue Feb 12, 2023
@mkoeppe
Merge sagemath#32625
f9207fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe