Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate sage.misc.package functions standard_packages, optional_packages, experimental_packages #30747

Closed
mkoeppe opened this issue Oct 8, 2020 · 24 comments
Closed

Deprecate sage.misc.package functions standard_packages, optional_packages, experimental_packages #30747

mkoeppe opened this issue Oct 8, 2020 · 24 comments
Labels
p: minor / 4 t: enhancement t: refactoring
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 8, 2020

These functions are superseded by the more general function list_packages.

This is also a step toward deprecating all of sage.misc.package.

CC: @antonio-rojas @jhpalmieri @kiwifb @isuruf

Component: refactoring

Author: Matthias Koeppe

Branch: 8ccc157

Reviewer: John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30747
@mkoeppe mkoeppe added this to the sage-9.2 milestone Oct 8, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

Changed dependencies from #30746 to #30746, #30712

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

Changed dependencies from #30746, #30712 to #30746, #30712, #30748

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 1, 2020

Changed dependencies from #30746, #30712, #30748 to #30746, #30712, #30846

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 2, 2020

Branch: u/mkoeppe/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2020

New commits:

8ab2285Gracefully fail if pip is not correctly installed
ec90687Merge branch 'public/build/hardenPip' of git://trac.sagemath.org/sage into t/30747/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror
044fcc0Move sage-list-packages from src/bin (sagelib) to build/bin (sage_bootstrap)
0085fdeMerge branch 'u/mkoeppe/move__src_bin_sage_list_packages__to__build_bin_' of git://trac.sagemath.org/sage into t/30747/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror
f2a4e39sage.misc.package: Deprecate standard_packages, optional_packages, experimental_packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2020

Commit: f2a4e39

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2020

Changed dependencies from #30746, #30712, #30846 to #30712, #30846

@mkoeppe mkoeppe changed the title Deprecate all of sage.misc.package except for PackageNotFoundError Deprecate sage.misc.package functions standard_packages, optional_packages, experimental_packages Nov 7, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 20, 2020

Changed dependencies from #30712, #30846 to none

@mkoeppe

This comment has been minimized.

Sign in to view
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 20, 2020

Changed commit from f2a4e39 to 8ccc157

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 20, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8ccc157sage.misc.package: Deprecate standard_packages, optional_packages, experimental_packages

@jhpalmieri
Copy link
Member

comment:11

Looks okay to me.

@jhpalmieri
Copy link
Member

Reviewer: John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2020

comment:12

positive review?

@jhpalmieri
Copy link
Member

comment:13

Yes, sorry.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2020

comment:14

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 6, 2020

Changed branch from u/mkoeppe/deprecate_all_of_sage_misc_package_except_for_packagenotfounderror to 8ccc157

@vbraun vbraun closed this as completed in 3290413 Dec 6, 2020
@fchapoton
Copy link
Contributor

Changed commit from 8ccc157 to none

@fchapoton
Copy link
Contributor

comment:16

the doctests in misc/package are sometimes failing, see

https://patchbot.sagemath.org/log/31060/Linux/60-Ubuntu_SMP_Fri_Nov_6_10:37:59_UTC_2020/x86_64/5.4.0-54-generic/petitbonum/2020-12-16%2023:45:16?short

which is running sage with python 3.9

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 18, 2020

comment:17

Replying to @fchapoton:

the doctests in misc/package are sometimes failing, see

https://patchbot.sagemath.org/log/31060/Linux/60-Ubuntu_SMP_Fri_Nov_6_10:37:59_UTC_2020/x86_64/5.4.0-54-generic/petitbonum/2020-12-16%2023:45:16?short

As part of #30940, some of these doctests are made less strict so that they work better in incremental builds that have some old packages still installed. - Needs review

@timokau timokau mentioned this issue Oct 31, 2020
Closed
mkoeppe added a commit to mkoeppe/sage that referenced this issue Apr 23, 2024
@mkoeppe
src/sage/misc/package.py: Remove code deprecated in sagemath#30747 (2…
afc2378 
…020)
vbraun pushed a commit to vbraun/sage that referenced this issue Apr 28, 2024
sagemathgh-37855: sage.misc.package: Remove deprecated code
a53ed51 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Remove code deprecated in:
- sagemath#31013 (2022)
- sagemath#30747 (2020)
- sagemath#30607 (2020)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37855
Reported by: Matthias Köppe
Reviewer(s): François Bissey, Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this issue May 2, 2024
sagemathgh-37855: sage.misc.package: Remove deprecated code
6753fbd 
    
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes sagemath#12345". -->

Remove code deprecated in:
- sagemath#31013 (2022)
- sagemath#30747 (2020)
- sagemath#30607 (2020)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#37855
Reported by: Matthias Köppe
Reviewer(s): François Bissey, Matthias Köppe
@mantepse mantepse mentioned this issue May 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: minor / 4 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
4 participants
@vbraun @jhpalmieri @fchapoton @mkoeppe