-
-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two-line fix for "./configure is too sensitive to stray files/subdirectories" #29120
Comments
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:3
The branch is on top of sage 8.7. New commits:
|
Author: Matthias Koeppe |
Reviewer: Dima Pasechnik |
comment:7
lgtm |
comment:8
Thanks! |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:10
Sometimes 2 lines are better than 1. |
comment:12
Could we please avoid |
comment:13
I think it's better if the diff is small. |
comment:14
I don't like this Fortran coding style, but OK :-) |
comment:15
Thanks! |
comment:16
+1 thanks. |
Changed branch from u/mkoeppe/one-line-fix-configure-too-sensitive-to-stray-files-in-build-pkgs to |
This branch can be merged by people who are working with tickets pre-9.1.beta2 who cannot easily merge current develop into that ticket.
It turns an error issued by
configure
when they are stray files inbuild/pkgs
(such as the generated files introduced in #29038).Before this ticket:
After this ticket:
CC: @dimpase @embray @vbraun
Component: build
Author: Matthias Koeppe
Branch/Commit:
171181f
Reviewer: Dima Pasechnik
Issue created by migration from https://trac.sagemath.org/ticket/29120
The text was updated successfully, but these errors were encountered: