Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two-line fix for "./configure is too sensitive to stray files/subdirectories" #29120

Closed
mkoeppe opened this issue Jan 31, 2020 · 17 comments
Closed

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 31, 2020

This branch can be merged by people who are working with tickets pre-9.1.beta2 who cannot easily merge current develop into that ticket.

It turns an error issued by configure when they are stray files in build/pkgs (such as the generated files introduced in #29038).

Before this ticket:

$ mkdir -p build/pkgs/xyzzy/foo
$ ./bootstrap && ./configure
...
configure: error: "/Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/build/pkgs/xyzzy/type" is missing.

After this ticket:

...
configure: WARNING: "/Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/build/pkgs/xyzzy/type" is missing.  Leftovers from another branch?
...

CC: @dimpase @embray @vbraun

Component: build

Author: Matthias Koeppe

Branch/Commit: 171181f

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29120

@mkoeppe mkoeppe added this to the sage-9.1 milestone Jan 31, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

Commit: 1f193bf

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

comment:3

The branch is on top of sage 8.7.


New commits:

1f193bfIssue only a warning, not an error, if there are stray files in build/pkgs

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

Author: Matthias Koeppe

@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

comment:7

lgtm

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

comment:8

Thanks!

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 31, 2020

Changed commit from 1f193bf to 171181f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 31, 2020

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:

171181ffixup

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

comment:10

Sometimes 2 lines are better than 1.

@mkoeppe mkoeppe changed the title One-line fix for "./configure is too sensitive to stray files/subdirectories" Two-line fix for "./configure is too sensitive to stray files/subdirectories" Jan 31, 2020
@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

comment:12

Could we please avoid continue, by putting the stuff to run fully into then clause?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

comment:13

I think it's better if the diff is small.

@dimpase
Copy link
Member

dimpase commented Jan 31, 2020

comment:14

I don't like this Fortran coding style, but OK :-)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 31, 2020

comment:15

Thanks!

@embray
Copy link
Contributor

embray commented Feb 5, 2020

comment:16

+1 thanks.

@vbraun
Copy link
Member

vbraun commented Feb 10, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants