Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MR38: Fix documentation of spkg-configure.m4 and make output more verbose #28788

Closed
sagetrac-gitlab-bot mannequin opened this issue Nov 22, 2019 · 41 comments
Closed

MR38: Fix documentation of spkg-configure.m4 and make output more verbose #28788

sagetrac-gitlab-bot mannequin opened this issue Nov 22, 2019 · 41 comments
Labels
c: build: configure p: minor / 4 t: enhancement
Milestone
sage-9.1

Comments

@sagetrac-gitlab-bot
Copy link
Mannequin

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

This now produces the following output:

...
-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG yasm...
checking for yasm supporting the adox instruction... /usr/local/bin/yasm
configure: will use system package and not install SPKG yasm
-----------------------------------------------------------------------------
Checking whether SageMath should install SPKG zeromq...
configure: zeromq has already been installed by SageMath
## ----------------------------------------------------------------------- ##
## Build status for each package:                                          ##
## ----------------------------------------------------------------------- ##
4ti2-1.6.7.p0:                               does not support check for system package; optional, use "./configure --enable-4ti2" to install
alabaster-0.7.12:                            does not support check for system package; will be installed as an SPKG
appnope-0.1.0.p0:                            does not support check for system package; will be installed as an SPKG
arb-2.16.0.p0:                               no suitable system package; will be installed as an SPKG
atlas-3.10.2.p3:                             not required on your platform; SPKG will not be installed
autotools-20141105.p0:                       does not support check for system package; experimental, use "./configure --enable-autotools" to install
awali-1.0.2-190218:                          does not support check for system package; experimental, use "./configure --enable-awali" to install
babel-2.6.0:                                 does not support check for system package; will be installed as an SPKG
backports_abc-0.5:                           does not support check for system package; will be installed as an SPKG
backports_functools_lru_cache-1.5:           does not support check for system package; will be installed as an SPKG
backports_shutil_get_terminal_size-1.0.0.p1: does not support check for system package; will be installed as an SPKG
backports_ssl_match_hostname-3.5.0.1.p0:     does not support check for system package; will be installed as an SPKG
barvinok-0.41.1:                             does not support check for system package; optional, use "./configure --enable-barvinok" to install
benzene-20130630:                            does not support check for system package; optional, use "./configure --enable-benzene" to install
bleach-3.1.0:                                does not support check for system package; will be installed as an SPKG
bliss-0.73+debian-1+sage-2016-08-02.p0:      does not support check for system package; optional, use "./configure --enable-bliss" to install
boost-1_66_0:                                no suitable system package; optional, use "./configure --enable-boost" to install
boost_cropped-1.66.0.p0:                     already installed as an SPKG
brial-1.2.5:                                 does not support check for system package; will be installed as an SPKG
buckygen-1.1:                                does not support check for system package; optional, use "./configure --enable-buckygen" to install
bzip2-1.0.6-20150304.p0:                     using system package; SPKG will not be installed
cbc-2.9.4.p0:                                no suitable system package; optional, use "./configure --enable-cbc" to install
ccache-3.3.4:                                does not support check for system package; optional, use "./configure --enable-ccache" to install
cddlib-0.94j:                                does not support check for system package; will be installed as an SPKG
certifi-2019.3.9:                            does not support check for system package; will be installed as an SPKG
cliquer-1.21.p4:                             already installed as an SPKG
cmake-3.11.0:                                using system package; SPKG will not be installed
cocoalib-0.99564:                            does not support check for system package; experimental, use "./configure --enable-cocoalib" to install
combinatorial_designs-20140630.p0:           does not support check for system package; will be installed as an SPKG
compilerwrapper-1.2:                         does not support check for system package; experimental, use "./configure --enable-compilerwrapper" to install
configparser-3.7.4:                          does not support check for system package; will be installed as an SPKG
configure-e4607fdd24b7921f03499d3cba645ea2d14f7d87:does not support check for system package; came preinstalled with the SageMath tarball
conway_polynomials-0.5:                      does not support check for system package; will be installed as an SPKG
coxeter3-8ac9c71723c8ca57a836d6381aed125261e44e9e:does not support check for system package; optional, use "./configure --enable-coxeter3" to install
cryptominisat-5.6.8:                         does not support check for system package; optional, use "./configure --enable-cryptominisat" to install
csdp-6.2.p0:                                 does not support check for system package; optional, use "./configure --enable-csdp" to install
curl-7.62.0.p0:                              using system package; SPKG will not be installed
cvxopt-1.2.3:                                does not support check for system package; will be installed as an SPKG
cycler-0.10.0.p0:                            does not support check for system package; will be installed as an SPKG
cypari-2.1.1:                                does not support check for system package; will be installed as an SPKG
cysignals-1.10.2:                            does not support check for system package; will be installed as an SPKG
cython-0.29.12.p0:                           does not support check for system package; will be installed as an SPKG
d3js-3.4.8:                                  does not support check for system package; optional, use "./configure --enable-d3js" to install
database_cremona_ellcurve-20190911:          does not support check for system package; optional, use "./configure --enable-database_cremona_ellcurve" to install
database_jones_numfield-4:                   does not support check for system package; optional, use "./configure --enable-database_jones_numfield" to install
...

(Earlier version: merge request at https://gitlab.com/sagemath/sage/-/merge_requests/38)

Depends on #29120

CC: @embray @jhpalmieri @mkoeppe

Component: build: configure

Author: Julian Rüth, Matthias Koeppe

Branch: bef6d57

Reviewer: Matthias Koeppe, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/28788
@sagetrac-gitlab-bot sagetrac-gitlab-bot mannequin added this to the sage-9.0 milestone Nov 22, 2019
@saraedum

This comment has been minimized.

Sign in to view
@saraedum

This comment has been minimized.

Sign in to view
@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

Changed commit from 84a6e82 to cabfe1f

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

comment:3

New commits added to merge request. I updated the commit SHA-1. New commits:

cabfe1ffix use of polymorphic variable

@sagetrac-gitlab-bot

This comment has been minimized.

Sign in to view
@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

Changed commit from cabfe1f to 146eaab

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

comment:5

New commits added to merge request. I updated the commit SHA-1. New commits:

146eaabalign code for readability

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

Changed commit from 146eaab to 7f889c1

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Nov 22, 2019

comment:6

New commits added to merge request. I updated the commit SHA-1. New commits:

7f889c1fix yasm require check

@saraedum

This comment has been minimized.

Sign in to view
@saraedum
Copy link
Member

comment:8

I made some remarks on GitLab. Looking forward to comments at https://gitlab.com/sagemath/sage/merge_requests/38.

@jhpalmieri
Copy link
Member

comment:9

config.log is still misleading:

result: no
no suitable system package found for SPKG rw
configure:20250: make will build and install the following SPKGs...
     4ti2-1.6.7.p0
     alabaster-0.7.12
     appnope-0.1.0.p0
     arb-2.16.0.p0 (no suitable system package)
     atlas-3.10.2.p3
     ...
     bzip2-1.0.6-20150304.p0 (using system package; will not be installed)
     ...

4ti2 and atlas are optional, and so they will not in fact be installed unless explicitly instructed via a command like make 4ti2. The package bzip2 is listed in this group of packages that make will build and installed, but with a note saying that it won't be installed. (Note also that make bzip2 will install bzip2, even though there is a valid system package.)

Also it would help to have a divider between the last test ("no suitable system package found for SPKG rw") and the start of the summary.

I would prefer to see something like

checking for library containing calculate_level... no
configure: no suitable system package found for SPKG rw
------------
configure: build status for each package:
   4ti2-1.6.7.p0: optional; not installed by default
   alabaster-0.7.12: will be installed
   appnope-0.1.0.p0: will be installed
   arb-2.16.0.p0: no suitable system package; will be installed
   atlas-3.10.2.p3: optional; not installed by default
   ...
   bzip2-1.0.6-20150304.p0: using system package; will not be installed
   ...

@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:10

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 22, 2020

comment:12

Related: #28095 - Add --enable-OPTIONALSPKG options to configure

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 6, 2020

comment:13

New commits added to merge request. I updated the commit SHA-1. New commits:

275225achange wording & layout of build status header
455b550Explain which packages are not going to be installed

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 6, 2020

Changed commit from 7f889c1 to 455b550

@sagetrac-gitlab-bot

This comment has been minimized.

Sign in to view
@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 6, 2020

Changed commit from 455b550 to 5863ac7

@sagetrac-gitlab-bot
Copy link
Mannequin Author

sagetrac-gitlab-bot mannequin commented Feb 6, 2020

comment:15

New commits added to merge request. I updated the commit SHA-1. New commits:

5863ac7Make sage_require_ follow the documentation

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 6, 2020

Reviewer: Matthias Koeppe

@jhpalmieri
Copy link
Member

comment:18

I get a merge failure with 9.1.beta3. Once fixed, please feel free to set back to positive review.

@jhpalmieri
Copy link
Member

comment:19

Actually, I have another request. The output in the ticket description, including

configure: will use system package and not install SPKG zeromq
## ------------------------------ ##
## build status for each package: ##
## ------------------------------ ##
    4ti2-1.6.7.p0: does not support check for system package yet; optional, will not be installed unless requested

is what is printed on the screen, but the config.log file shows

configure:25323: will use system package and not install SPKG zeromq
configure:28740: result:     4ti2-1.6.7.p0: does not support check for system package yet; optional, will not be installed unless requested

with no text separating the last test from the summary. Can you add some text there so I can easily search config.log to find the spot where the summary starts?

Indeed, perhaps all of the summary text ("checking whether SageMath should install SPKG tachyon", etc.) should be included in the log file, not just on the screen.

@jhpalmieri
Copy link
Member

comment:20

To explain a bit more about my last comment: I am much more likely to look through the log file than to see the mass of text whiz by on the screen, so (assuming I'm not the only one) the log file should have formatting at least as good as what's on the screen.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 7, 2020

comment:21

I agree, everything that is printed on the screen should also appear in the log file.

@saraedum
Copy link
Member

saraedum commented Feb 7, 2020

comment:22

I won't continue on this one. If you are unhappy with autoconf defaults, feel free to work around them.

@jhpalmieri
Copy link
Member

comment:23

mkoeppe: I don't know autoconf syntax, but if you can do the last fixes, I can review.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2020

Changed branch from u/galois/mrs/38/verbose-configure to u/mkoeppe/mrs/38/verbose-configure

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

bef6d57Improve spkg messages

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 9, 2020

Changed commit from 5863ac7 to bef6d57

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2020

Changed author from Julian Rüth to Julian Rüth, Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2020

Dependencies: #29120

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2020

comment:28

Replying to @jhpalmieri:

mkoeppe: I don't know autoconf syntax, but if you can do the last fixes, I can review.

Ready for review.

@jhpalmieri
Copy link
Member

Changed reviewer from Matthias Koeppe to Matthias Koeppe, John Palmieri

@jhpalmieri
Copy link
Member

comment:29

Looks good to me, thanks! And thanks very much to saraedum for leading the efforts on this. Sorry to be so picky.

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 9, 2020

comment:31

Thank you!

@vbraun
Copy link
Member

vbraun commented Feb 11, 2020

Changed branch from u/mkoeppe/mrs/38/verbose-configure to bef6d57

@vbraun vbraun closed this as completed in ead6f55 Feb 11, 2020
@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 17, 2020

comment:33

Follow up: #29211

@mkoeppe
Copy link
Contributor

mkoeppe commented Feb 17, 2020

Changed commit from bef6d57 to none

@embray embray mentioned this issue Mar 18, 2020
Closed
@saraedum saraedum mentioned this issue Nov 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
5 participants
@saraedum @embray @vbraun @jhpalmieri @mkoeppe