spkg-configure for cddlib

[dimpase]

Provide spkg-configure.m4 to use libcdd/cdd from the system.

This ticket is limited to systems that install headers into /usr/include rather than /usr/include/cdd (Debian) or /usr/include/cddlib (Fedora).

Follow-up: #29413 (Upgrade cddlib, fix cddlib header search for packages latte_int, gfan, topcom)

CC: @saraedum @orlitzky

Component: build: configure

Author: Dima Pasechnik, Michael Orlitzky

Branch/Commit: de9fb2e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/28905

[mkoeppe]

comment:2

See also cddlib/cddlib#26 "Consider installing headers in ${prefix}/include/cdd/ instead of ${prefix}/include"

[saraedum]

comment:4

Sorry, I fail to understand the description of this ticket. What are you trying to achieve here exactly? Would be nice if you could elaborate a bit.

[dimpase]

comment:5

The goal is to use libcdd/cdd from the system (as in all tickets from #27330).
There should not be a problem with headers, after all we can install links to $SAGE_LOCAL/include/. I don't know which cdd executables are used in Sagemath.
Again,for these we can install links in SAGE_LOCAL/bin/.

[dimpase]

comment:6

Am I right that the only parts of cdd(lib) currently used in Sage are executables cddexec* ? If so, it would be trivial to provide spkg-configure.m4.

[dimpase]

Commit: 5b8ca8f

[dimpase]

Branch: u/dimpase/packages/cddlibconfig

[dimpase]

Author: Dima Pasechnik

[dimpase]

New commits:

5b8ca8f

spkg-configure for cddlib

[dimpase]

comment:8

cddlib is used as a library in gfan and latte. So one needs a check for headers and libraries.

[orlitzky]

comment:9

I did some work on this but the version of cddlib in Gentoo is too old to detect, so now I have to go fix that first.

[orlitzky]

Changed branch from u/dimpase/packages/cddlibconfig to u/mjo/ticket/28905

[orlitzky]

Changed commit from 5b8ca8f to 61117fd

[kiwifb]

comment:10

Replying to @orlitzky:

I did some work on this but the version of cddlib in Gentoo is too old to detect, so now I have to go fix that first.

Yes the version from the main tree is too old. I have a newer suitable version in the sage-on-gentoo overlay.

[mkoeppe]

comment:11

Is there a branch to test?

[orlitzky]

comment:12

Yeah, the one up there works for me. We did get cddlib upgraded in Gentoo and my branch detects it.

[mkoeppe]

comment:13

Are there Dockerfiles or Docker images available that allow testing of the Gentoo Sage distribution?
Off-topic for this ticket - but I would like to add a continuous integration test for https://github.com/mkoeppe/sage-numerical-backends-coin

[kiwifb]

comment:14

Replying to @mkoeppe:

Are there Dockerfiles or Docker images available that allow testing of the Gentoo Sage distribution?
Off-topic for this ticket - but I would like to add a continuous integration test for https://github.com/mkoeppe/sage-numerical-backends-coin

coinor is too old in Gentoo. I tried to do an upgrade privately sometime last year. Unfortunately I lost the ebuilds in a mishap (and they weren't on vcs yet when it happened). I couldn't get it to work with sage which was annoying.

[mkoeppe]

comment:15

I primarily want to test with Gentoo's sage, not Gentoo's coinor. I can bring my own coinor from coinbrew.

[mkoeppe]

comment:16

FYI - https://github.com/mkoeppe/sage-numerical-backends-coin/blob/master/tox.ini

[kiwifb]

comment:17

Well I don't produce any docker images and I don't know if someone else did. Would be neat.

[orlitzky]

comment:18

The closest thing to a Docker image we have are the KVM images that the openstack project maintains:

http://gentoo.osuosl.org/experimental/amd64/openstack/

In theory you can boot one of those up, configure the sage-on-gentoo overlay,

https://github.com/cschwan/sage-on-gentoo

and then emerge sage. But each of those steps is tricky if you've never done it.

I'm slowly working on moving things from the overlay to the main gentoo repository, so that one day you can "emerge sage" without the overlay. (Basically, I'm just taking Francois's work and committing it to the main repository.)

This goes hand-in-hand with the spkg-configure work because in the past, while sage-on-gentoo provides the most stable and usable sage, it doesn't help me rebuild sage.git for testing tickets. But now whenever a package gets an spkg-configure.m4, adding that package to gentoo both (1) speeds up the sage.git build, and (2) brings the overlay one step closer to the main repository.

[orlitzky]

comment:31

I think the best solution is to:

1. Merge this now, since it's correct with respect to the rest of the (current) tree.
2. Report the fact that the headers can be installed in non-standard locations to lattE/gfan upstream.
3. (a) If those packages make the header search more robust, great; we upgrade the spkgs and we're done. (b) If they say they won't, then we hack something together as in #28905 comment:29.
4. We update the spkg-configure.m4 for cddlib to look in the non-standard locations as well.
5. If cddlib upstream ever moves the headers, we can (at our leisure) simplify all of the checks.

[saraedum]

comment:32

I am happy to accept a PR at cddlib upstream to install the headers into cdd/ on GitHub btw.

[orlitzky]

comment:33

The next release of cddlib will use the cddlib prefix for its headers. But for now, our latte and gfan packages only look for the bare cdd.h, so that's what we need to check for. Can we merge this now, and then update things as they change?

[mkoeppe]

comment:34

Could you update the comment in the added file regarding the header file locations?

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8508639	spkg-configure for cddlib
27d5c6b	Trac #28905: add header/library checks for cddlib.

[sagetrac-git]

Changed commit from 61117fd to 27d5c6b

[orlitzky]

comment:36

Sure, I added a real commit message too.

[orlitzky]

Changed author from Dima Pasechnik to Dima Pasechnik, Michael Orlitzky

[mkoeppe]

Changed branch from u/mjo/ticket/28905 to u/mkoeppe/ticket/28905

[mkoeppe]

comment:39

Rebased to 9.1.beta8

---

New commits:

082be67	spkg-configure for cddlib
16b78ac	Trac #28905: add header/library checks for cddlib.

[mkoeppe]

Changed commit from 27d5c6b to 16b78ac

[mkoeppe]

comment:40

sorry, I messed this one up

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8508639	spkg-configure for cddlib
27d5c6b	Trac #28905: add header/library checks for cddlib.

[sagetrac-git]

Changed commit from 16b78ac to 27d5c6b

[mkoeppe]

comment:42

Set it back to your commit

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0f04c3b	build/pkgs/cddlib/distros/*.txt: New
de9fb2e	build/pkgs/cddlib: Add upstream_url

[sagetrac-git]

Changed commit from 27d5c6b to de9fb2e

[mkoeppe]

comment:44

Testing at https://github.com/mkoeppe/sage/actions/runs/64126739

[mkoeppe]

Reviewer: Matthias Koeppe

[mkoeppe]

comment:46

Detects cddlib correctly on archlinux-latest-standard (https://github.com/mkoeppe/sage/runs/537774833).

We don't have a test for Gentoo (#29105, hint hint), but I assume you have tested it there.

As expected, not detected on debian and fedora. I have created follow-up ticket #29413 for that and edited the ticket description.

[vbraun]

Changed branch from u/mkoeppe/ticket/28905 to de9fb2e