-
-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modernize sage.rings.real_mpfr #24457
Comments
Dependencies: #24456 |
Author: Ralf Stephan |
Changed branch from #24456 to none |
comment:2
In |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:6
This commit changes 164 files. Preliminary testing passes in rings and src/doc. There might be subtle errors introduced in the documentation. Let's try the patchbots. New commits:
|
Commit: |
comment:7
Ah I forgot the string representation part. |
comment:8
Sorry, I was pretty sure I excluded |
Changed branch from u/rws/rename_sage_rings_real_mpfr_realfield to none |
Changed commit from |
Branch: u/rws/24457-1 |
Commit: |
comment:10
After changing the string representation as well: New commits:
|
Changed branch from u/rws/24457-1 to u/rws/24457-2 |
New commits:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:41
Let us do that incrementally (ie each subtask in ticket). It will simplify review and merging. Though I would feel much more confortable if the whole task would be actually closed within the next stable release. |
comment:42
Replying to @videlec:
Though it would be better to first change the names:
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
comment:48
Rebased on the remaining dependency. |
comment:49
OOps wrong ticket. |
Changed dependencies from #24511 to none |
comment:51
update milestone 8.3 -> 8.4 |
The current
sage.rings.real_mpfr
deals with arbitrary precision floating-point numbers (using mpfr). This is the default "real field" in many places in Sage even though it is often wiser to use intervals or balls. We perform some cosmetic changes tosage.rings.real_mpfr
to emphasize the fact that the module deals with floating-point approximations of real numbers and not genuine reals. These modifications touch a lot of files and involve deprecation of widely used names.See also the introduction of a genuine real field class in #24456 for another motivation.
step 1
create_RealField
inreal_field.py
RealField
->RealFloatingPointField_factory
RealField_class
->RealFloatingPointField
RealNumber
->RealFloatingPoint
is_RealNumber(x)
andis_RealField(x)
in favour ofisinstance(x, RealFloatingPoint)
andisinstance(x, RealFloatingPointField)
step 2
RR
andReals
and useRFF
(orRFPF
?) as the standard name forRealFloatingPointField(53)
?for complex numbers, see #24489.
Component: basic arithmetic
Issue created by migration from https://trac.sagemath.org/ticket/24457
The text was updated successfully, but these errors were encountered: