-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jupyter R kernel #19427
Comments
Branch: u/vbraun/jupyter_r_kernel |
Author: Volker Braun |
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:3
Note: need to |
comment:4
Could you please add a |
comment:5
scripts depend on all standard packages (just like optional ones). It also depends on jupyter as it calls it to install its kernel specs. On the one hand it would be nice to have the dependencies explicit, but they would also just be wrong if we can't actually test them. |
comment:6
Replying to @vbraun:
This describes a way to test dependencies: If I would certainly like to make |
comment:7
Still, whats the point? Some packages can't be standard so depending on standard doesn't cost us anything. Whereas additional complexity, new ways of introducing dependency errors, and insufficient test coverage are very real downsides. |
comment:8
Shouldn't the |
Attachment: Untitled3-native.pdf.gz A few notebook commands with 6.10rc0+Trac#19427 |
A few notebook commands with 6.10rc0+Trac#19638(rpy2 update)+ manual installation of IRKernel |
comment:11
Attachment: Untitled3-19638.pdf.gz Dear Volker,
You can compare these results (illustrated in "Untitled3-native.pdf") with those obtained on 6.10rc0+Trac#19638+manual installation of IRKernel in R, which also illustrates the problems with this current implementation :
If your goal was strictly limited to providing an R notebook in Sage's Jupyter, I think it's good to go. If you aimed at providing Sage with an alternative interface to R, it needs work (needs Trac#19638, IMHO, but I'm biased...). I would be interested in your point of view in the question I posed in sage-devel. William's sarcastic non-answer misses a part of the point. Sincerely yours, |
comment:12
This ticket has nothing to do with rpy2, its only about the jupyter R kernel. Really they are two totally independent approaches to using R, one from within Python and the other without Python. |
Reviewer: Emmanuel Charpentier |
comment:13
Replying to @vbraun:
[ Sorry for the delay. I was busy... ] Okay. This clarification (that should go in the description) enables positive review. |
Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:
|
Changed branch from u/vbraun/jupyter_r_kernel to |
This introduces a new "script" type of packages that only run a script. This is supposed to be an alternative for optional/experimental packages so we can use third-party package managers to install things.
In this case, the R package manager, though it would presumably be useful for TexLive (instead of
src/ext/texlive/texlive-install
) and npm. But thats for future tickets...CC: @jdemeyer @EmmanuelCharpentier
Component: packages: optional
Author: Volker Braun
Branch/Commit:
7316730
Reviewer: Emmanuel Charpentier
Issue created by migration from https://trac.sagemath.org/ticket/19427
The text was updated successfully, but these errors were encountered: