-
-
Notifications
You must be signed in to change notification settings - Fork 487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade rpy2 to 2.7.5 #19638
Comments
comment:1
Extract from this question on sage-devel : My pip upgrade showed me that this upgrade entails :
ISTR that, on sage-devel, it has been decided that a new package should remain optional for at least a year before becoming a standard package. If we follow this policy, the standard package rpy2 would depend on the optional package singledispatch. This seems a bit incoherent... Another solution would be to keep the standard rpy2 package at 2.3.8, and have a rpy2-newer optional, depending on A third solution would be to silently include singledispatch in the source to rpy2. This "solution" seems to guarantee future incompatibilities. What should I do ? Bonus question : how to package rpy2 to signal that it depends on singledispatch ? |
Branch: u/charpent/upgrade_rpy2_to_2_7_4 |
Commit: |
Author: Emmanuel Charpentier |
This comment has been minimized.
This comment has been minimized.
comment:3
This version does the job ( Not yet ready for review, because :
Any suggestion on how to document the Jupyter interface ? |
Attachment: singledispatch-3.4.0.3.tar.gz Tarball for the new sigledispatch package |
Attachment: six-1.10.0.tar.gz New tarball for six |
New tarball for rpy2 |
comment:4
Attachment: rpy2-2.7.4.tar.gz Our damn "corporate" firewall mangled the upload of new tarballs... |
comment:5
Passes I still haven't the foggiest idea about where to document the Jupyter interface. We need to mention four things at the very minimum :
By the way, the Jupyter notebook doesn't seem documented in the Sage documentation. |
comment:6
We don't put tarball in attachment anymore, we rarely put any attachment anymore actually. We usually put a pointer to where to download the source in the description, see for example #10295. |
comment:7
Links to the original tarballs added in the description. I'm still waiting for comments on the right place to add documentation. |
This comment has been minimized.
This comment has been minimized.
comment:8
I honestly don't know where to document it in this case. You may have to try to stir things up on sage-devel. The warning you get from |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Passes ptestlong when added to a pristine 6.10rc0 git clone. Embryonic documentation added as an addendum to the r interface documentation. It appears that, while useful in its present state, this work should be extended to a (re-)implementation of the R interface (our present implementation uses expect). I shall question sage-devel and open another ticket for this. Still requiring review. |
Reviewer: François Bissey |
comment:12
Good enough for me. I have been using |
comment:13
|
New tarball for rpy2-2.7.5 |
comment:14
Attachment: rpy2-2.7.5.tar.gz Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. New commits:
|
comment:15
Passes ptestlong. |
This comment has been minimized.
This comment has been minimized.
comment:16
I have verified this. |
comment:17
Replying to @tscrim:
Thanks. You should add your (real) name to the "Reviewers" field... |
Changed reviewer from François Bissey to François Bissey, Travis Scrimshaw |
comment:19
Please don't attach tarballs to trac tickets, they just end up in our trac database forever |
Changed branch from u/charpent/upgrade_rpy2_to_2_7_4 to |
Changed commit from |
Changed reviewer from François Bissey, Travis Scrimshaw to François Bissey, Travis Scrimshaw |
The current version (2.3.8) of
rpy2
packaged in Sage is too old to work with the current version of the Jupyter notebookManually upgrading to 2.7.4 (via
sage -pip install --upgrade rpy2
seems to work. However in also upgradessix
(to1.10.0-py2.py3-non-any.whl
(???) andsingledispatch
(but seems to use the current (cached) version).I also get the following warning :
DEPRECATION: Uninstalling a distutils installed project (rpy2) has been deprecated and will be removed in a future version. This is due to the fact that uninstalling a distutils project will only partially uninstall the project.
which I do not really understand....
New tarballs attached ; you may also download rpy2, six and singledispatch directly from python.org.
Edit : version bumped to 2.7.5
CC: @kiwifb
Component: packages: standard
Keywords: r-project jupyter
Author: Emmanuel Charpentier
Branch:
50462d2
Reviewer: François Bissey, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/19638
The text was updated successfully, but these errors were encountered: