-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add methods to rigged configurations #15560
Comments
Commit: |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:8
Thanks in advance for doing the review. |
comment:9
Hi Travis, Here are further comments:
This is not a sentence. Perhaps you want "If we are constructing"? Also, it would be great to add left_split as a method to KirillovReshetikhinTableaux and possibly also the right_split method! This can be just done by using the bijection to rigged configurations, but it would be very handy to have these methods directly on KirillovReshetikhinTableaux as well. Thanks, Anne |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Reviewer: Anne Schilling |
comment:12
Here's the major changes:
Best, Travis |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:22
Hi Travis, Here are some more comments:
Anne |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:24
Replying to @anneschilling:
I couldn't find this and the documentation built without an issue and looks okay to me (although there was a missing 'u').
Added under the name
This was due to before, the element constructor always preserved the vacancy numbers and now it recomputes it unless explicitly stated. Fixed with added tests. I expanded the documentation in |
comment:25
Replying to @tscrim:
There is a ` missing in
Under
Even though it is stated in the documentation, that
What is the difference between Anne |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:28
Replying to @anneschilling:
Ah, I forgot about the right split for KR tableaux. :P Fixed.
I've added a doctest.
This is because this was not a parameter in
The first one constructs and returns the graph, the latter outputs each step to the terminal. I've changed |
comment:29
Why is the right_split that you implemented the correct map? I thought that rs = * ls * using the * map. |
comment:30
Replying to @anneschilling:
|
comment:31
With your current code
I think you need to use complement in the definition the RC side. Also, it might be better to rename |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:34
Hi Travis, Thanks for the changes. I get the following failure when trying to play with the code
Anne |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:36
Hey Anne, I've removed the |
comment:37
Ok, looks good now! Anne |
Changed branch from public/combinat/rigged_configurations/methods-15560 to |
Adds some extra methods to rigged configurations: the action of the left column splitting and the basic operation in the bijection with tensor product of KR tableaux.
Depends on #13872
Depends on #15882
CC: @sagetrac-sage-combinat @anneschilling
Component: combinatorics
Keywords: rigged configurations
Author: Travis Scrimshaw
Branch/Commit:
1e15993
Reviewer: Anne Schilling
Issue created by migration from https://trac.sagemath.org/ticket/15560
The text was updated successfully, but these errors were encountered: