Maxima 5.26.0 update to make it install with also the new ASDF (ECL 12.x)

[dimpase]

ECL has moved to use a new ASDF, which means that as of ECL 12, the maxima 5.26.0 spkg stops working with it, due to a small change in the naming scheme of intermediary files.
The update takes care of this, and the patched spkg works with both the current ASDF and the new ASDF.

The updated spkg: http://boxen.math.washington.edu/home/dima/packages/maxima-5.26.0.p1.spkg

---

The main purpose of this ticket is to allow the new ECL from #13324 (with a couple of valuable fixes) to get merged before the new Maxima spkg (5.29.1, #13364) is ready (which unfortunately is unlikely to happen very soon).

CC: @jpflori @nexttime @kcrisman

Component: symbolics

Author: Dmitrii Pasechnik

Reviewer: Leif Leonhardy

Merged: sage-5.6.beta2

Issue created by migration from https://trac.sagemath.org/ticket/13860

[nexttime]

Author: Dima Pasechnik

[nexttime]

Reviewer: Leif Leonhardy

[nexttime]

comment:2

I've only read the attached patch (why "41", and what's the first file?), but that still contains the bug w.r.t. check_error() (see #13364).

It would also be better to use cp -p[f] ... (and delete some PDF files if we don't install them anyway; cf. #12759).

[nexttime]

comment:3

I'd also use elif [[ -f maxima.fasb ]]; then ..., since the non-presence of maxima.system.fasb doesn't really imply "Old ASDF".

[dimpase]

comment:4

OK, all fixed, please see the updated spkg - and p0tp1_changes.patch.

Please ignore diff41.* - they are for the previous revision.

[nexttime]

Changed author from Dima Pasechnik to Dmitrii Pasechnik

[nexttime]

comment:5

Replying to @dimpase:

OK, all fixed, please see the updated spkg - and p0tp1_changes.patch.

Patch looks ok.

Please ignore diff41.* - they are for the previous revision.

Deleted...

[nexttime]

comment:7

Replying to @nexttime:

Patch looks ok.

The spkg as well (and builds with both ECL 11.1 and 12.12; tests pass).

Merry Chrismas.

---

Deletion of some PDF files (we do not install) from the upstream tree belongs to spkg-dist (and/or should be mentioned in "Special !Update/Build Instructions"), but that's for another ticket, IMHO.

[jdemeyer]

comment:8

Replying to @nexttime:

Deletion of some PDF files (we do not install) from the upstream tree belongs to spkg-dist (and/or should be mentioned in "Special !Update/Build Instructions")

+1

[dimpase]

Attachment: p0top1_changes.patch.gz

spkg changes - for review only

[dimpase]

comment:9

Replying to @jdemeyer:

Replying to @nexttime:

Deletion of some PDF files (we do not install) from the upstream tree belongs to spkg-dist (and/or should be mentioned in "Special !Update/Build Instructions")

+1

added a line in spkg-dist for this. spkg updated.

[jpflori]

comment:10

I would have prefered to have the ticket number at the beginning of the changelog (and removed the reference at the end of the pwd part) and put a capital letter at the beginning of the third point, but that's not the most crucial point here.

It is just that I feel our spkgs lack some consistency (and the dev manual some clear guide on how to craft them).
And I'm not even thinking of the ATLAS spkg which uses Python :)

[jdemeyer]

Merged: sage-5.6.beta2