-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Maxima to 5.29.1 #13364
Comments
comment:1
From my test with 5.27.0 that will break a number of things.... The interface to a number of functions changed and requires extra arguments which throws things all over the place of course. |
comment:2
True. I just opened this in order to have a ticket for it at all; I couldn't find one for 5.27 update alone (as opposed to things noting that 5.27 would fix various things) so I opened this. Feel free to close it if it's a dup. |
comment:3
No duplicate that I know off. May be an opportunity to update ecl as well, 12.2.1 works well with a few tweaks. 12.7.1 seems to have issues see #12985. |
comment:4
The newest Maxima is now 5.29. Ugrading ECL is #13324 and hopefully will have positive review soon. |
comment:5
We'll have to make some change to spkg-install when ECL >= 12.12.1 gets in. I'm waiting for more info from upstream ECL on this change. |
Changed keywords from none to maxima spkg |
comment:7
Here comes a 5.29.1 spkg at It builds and runs and passes most tests in sage/calculus on Linux. |
Work Issues: fix doctets |
comment:9
Your spkg diff for the readme says that you removed a patch, but I don't see that in the diff. But we track the patches directory, right? |
comment:10
Yup, I forgot to run hg addremove. |
comment:11
It also seems Maxima does not integrate sqrt(x + sqrt(x)) anymore, maybe that needs assumptions which were incorectly assumed before, don't want to think about that now. |
comment:12
Yes, don't worry about this now, as François has put a lot of time into cataloguing things anyway on some sage-devel discussion a while ago. |
comment:13
Could you provide a link to that discussion? |
comment:14
No, it's too old, I'm not sure how to find it. It wasn't part of a thread only about this, I think. François, do you remember? |
comment:15
Haven't tried 5.29.1 only 5.28 after it came out. I remember that a number of function now require an extra argument (an assumption) as you have found out. But I haven't looked at it in a long time. I'll check what I can find. |
comment:16
Actually I haven't done a report on upgrade that break things badly for a little while. You may remember a report from a long time ago. I don't have as much time to write those these days. |
comment:17
Doing some tests with ecl 12.2.1+maxima 5.29.1 right now. I assume the target will be 12.12.1 /5.29.1 and enabling unicode in ecl if possible. Anyway I have a nasty
Probably ecl/maxima rather than pure maxima it goes in a panic
for quite a bit before getting killed. The other interesting bits:
it is not as bad as I remember but it is just pinpointing on some obvious tests right now. |
comment:18
Replying to @kiwifb:
Yup 12.12.1 plus 5.29.1. I'd prefer to postpone Unicode and deal with it in let's say #12985, unless it is really trivial.
Nice, I did not get that one though.
Got these ones and similar in other places.
|
Dependencies: #13324 |
Author: Jean-Pierre Flori |
Changed work issues from fix doctets to fix doctests, build with latest ECL |
comment:21
The Maxima spkg fails to build for me because |
comment:22
Ok, now the build "succeeded", although I get:
(I think this was already mentioned on the ECL ticket. Not sure how the new library is supposed to work when it doesn't get installed...) I also get a couple of new warnings (w.r.t. Maxima 5.26.0 and the old ECL) like
(I.e., 164/2 [I think] instances of "Too few arguments for proclaimed function LOGAND".) |
comment:23
Replying to @nexttime:
as far as I understand, the name might have changed, due to asdf changes in ECL. |
Changed dependencies from #13324 to none |
comment:113
Replying to @kcrisman:
You are welcome, I guess :P |
comment:114
This spkg should be rebased to maxima-5.26.0.p1, it is currently based on maxima-5.26.0.p0. |
comment:115
Replying to @jdemeyer:
as far as I am concerned, maxima-5.26.0.p1 may just as well die. It would cost me half an hour of fooling around with hg, with 0 benefit for anything. |
comment:117
Replying to @jdemeyer:
When I worked on #13860 it was not clear that the current ticket can be done so fast. The changes on #13860 are all basically repeated, in a slightly different way, on this ticket. Due to our scheme of working on packages it wasn't trivial to properly merge the changes, so I just copy/pasted from source. |
comment:118
OK, I rebased. diff attached. I also renamed |
This comment has been minimized.
This comment has been minimized.
spkg diff, for review only |
comment:120
Attachment: maxima-5.29.1.p1.diff.gz |
comment:121
Replying to @jdemeyer:
dank u wel! |
comment:122
Agreed! |
comment:123
I've opened #13973 to deal with including the latest upstream patches. |
comment:124
Here are some tickets the current ticket should fix (i.e., they just need a patch to doctest it). Not that I've tried them, just that in theory they are in 5.29.1. Unfortunately, so far I only found these two... |
Merged: sage-5.7.beta0 |
comment:126
Note that this commit in Maxima apparently fixes one of the problems in question. |
The new spkg is for ECL 11 as well as for ECL 12, i.e. ASDF-agnostic, along the lines of maxima 5.26.0 at #13860. Moreover it has
an upstream patch preventing segfaults. This fixes few tickets.
Install http://boxen.math.washington.edu/home/jdemeyer/spkg/maxima-5.29.1.p1.spkg
Apply
Upstream: Reported upstream. Developers acknowledge bug.
CC: @jpflori @dimpase @nbruin @zimmermann6
Component: packages: standard
Keywords: maxima spkg
Author: Jean-Pierre Flori, Dmitrii Pasechnik
Reviewer: Karl-Dieter Crisman, François Bissey, Leif Leonhardy, Paul Zimmermann
Merged: sage-5.7.beta0
Issue created by migration from https://trac.sagemath.org/ticket/13364
The text was updated successfully, but these errors were encountered: