Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finite_class.py derived from deprecated Combinatorial Class has no comment #13552

Closed
sagetrac-startakovsky mannequin opened this issue Sep 30, 2012 · 10 comments
Closed

finite_class.py derived from deprecated Combinatorial Class has no comment #13552

sagetrac-startakovsky mannequin opened this issue Sep 30, 2012 · 10 comments
Assignees
@williamstein
Labels
c: combinatorics p: major / 3 t: enhancement
Milestone
sage-8.2

Comments

@sagetrac-startakovsky
Copy link
Mannequin

sagetrac-startakovsky mannequin commented Sep 30, 2012

Hi, This ticket is about entering a deprecation in finite_class.py to no longer use it and instead use FiniteEnumeratedSets.

finite_class.py (FiniteCombinatorialClass) is derived from CombinatorialClass, which has the comment:

   946     """
   947     This class is deprecated, and will disappear as soon as all derived
   948     classes in Sage's library will have been fixed. Please derive
   949     directly from Parent and use the category :class:`EnumeratedSets`,
   950     :class:`FiniteEnumeratedSets`, or :class:`InfiniteEnumeratedSets`, as
   951     appropriate.

We go a step further in and fully deprecate finite_class.py and redirects them to use/develop FiniteEnumeratedSets instead.

CC: @tscrim @nthiery @hivert

Component: combinatorics

Author: Frédéric Chapoton

Branch/Commit: 006ce0e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/13552
@sagetrac-startakovsky sagetrac-startakovsky mannequin added this to the sage-5.11 milestone Sep 30, 2012
@sagetrac-startakovsky

This comment has been minimized.

Sign in to view
@KPanComputes
Copy link

comment:2

Ouch, I did not intend to change the owner to "was"! Not sure how to fix it now; I seem to be unable to remodify. Anyway, I only hope I have not done any harm.

@jdemeyer jdemeyer modified the milestones: sage-5.11, sage-5.12 Aug 13, 2013
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.1, sage-6.2 Jan 30, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.2, sage-6.3 May 6, 2014
@sagetrac-vbraun-spam sagetrac-vbraun-spam mannequin modified the milestones: sage-6.3, sage-6.4 Aug 10, 2014
@fchapoton
Copy link
Contributor

Branch: u/chapoton/13552

@fchapoton
Copy link
Contributor

Commit: 006ce0e

@fchapoton
Copy link
Contributor

Author: Frédéric Chapoton

@fchapoton
Copy link
Contributor

New commits:

006ce0etrac 13552 deprecation of finite combinatorial class

@fchapoton fchapoton modified the milestones: sage-6.4, sage-8.2 Dec 19, 2017
@tscrim
Copy link
Collaborator

tscrim commented Dec 19, 2017

comment:8

LGTM.

@tscrim

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented Dec 19, 2017

Reviewer: Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Dec 22, 2017

Changed branch from u/chapoton/13552 to 006ce0e

@vbraun vbraun closed this as completed in 8ea1468 Dec 22, 2017
@fchapoton fchapoton mentioned this issue Jan 1, 2019
Closed
dkrenn added a commit to dkrenn/sage that referenced this issue Jul 4, 2023
@dkrenn
Merge tag '8.6' into u/dkrenn/joint-spectral-radius
121c8ba 
SageMath version 8.6, Release Date: 2019-01-15

* tag '8.6': (15673 commits)
  Updated SageMath version to 8.6
  Updated SageMath version to 8.6.rc1
  maxint -> maxsize, for py2/3 compatibility
  sagemath#26326 : 32-bit vs 64-bit doctests
  sagemath#26326 : reorder creation of random graphs to avoid creating an empty one by bad luck on 32-bit systems.
  Updated SageMath version to 8.6.rc0
  trac sagemath#26994: fix doctest in sql_db
  trivial cleanup
  force a UTF-8 locale on GAP in these tests
  allow setting additional environment variables when starting a Gap interface instance
  p_group_cohomology: Avoid conflict with a new global variable name in Gap
  Updated SageMath version to 8.6.beta1
  25501: adding missing optional tags
  Fix tox testsuite for sage_bootstrap
  trac 26980 fix script for python3
  trac 26978 remove module finite_class from doc
  a little firework of typos
  remove FiniteCombinatorialClass after sagemath#13552
  remove some deprecated thing in combinat/partition
  remove deprecated things in combinat/integer_vector
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@williamstein williamstein

Labels
c: combinatorics p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.2
Development

No branches or pull requests
6 participants
@vbraun @williamstein @tscrim @jdemeyer @fchapoton @KPanComputes