Update Maxima to the latest upstream release.

[sagetrac-drkirkby]

The version of Maxima in Sage (5.22.1) is not the latest (5.23.2), so we should update. We need to update this along with ECL at the same time (see #10766 for the ECL update).

There are some doctest issues when both ECL and Maxima are updated, which seems to be the case every single time these are updated. The patches to fix the doctests are on the ECL upgrade ticket.

Apply:

1. The dependency Update ECL to the latest upstream release. #10766 (ECL)
2. The new spkg http://spkg-upload.googlecode.com/files/maxima-5.23.2.spkg
3. attachment: trac_10773-fix_maxima_version.patch

CC: @kiwifb @kcrisman @jpflori

Component: packages: standard

Author: David Kirkby, François Bissey

Reviewer: David Kirkby, François Bissey, Karl-Dieter Crisman, Jean-Pierre Flori

Merged: sage-4.7.alpha1

Issue created by migration from https://trac.sagemath.org/ticket/10773

[sagetrac-drkirkby]

Attachment: 10773-update-Maxima-to-5.23.2.patch.gz

Shows changes to SPKG.txt - only for review purposes, as all changes are in .spkg

[sagetrac-drkirkby]

Author: David Kirkby

[kiwifb]

comment:3

This will need a patch in interface/maxima.py as maxima's version number is harcoded in 2 tests.

[kiwifb]

Fixing the doctests with hardcoded version of maxima

[kiwifb]

comment:4

Attachment: trac_10773-fix_maxima_version.patch.gz

Added a patch to sage/interfaces/maxima.py to fix maxima hardcoded version number.

[sagetrac-drkirkby]

Reviewer: David Kirkby

[sagetrac-drkirkby]

Changed author from David Kirkby to David Kirkby, François Bissey

[sagetrac-drkirkby]

comment:5

Replying to @kiwifb:

Added a patch to sage/interfaces/maxima.py to fix maxima hardcoded version number.

Thank you for that. It looks good to me, so I'm happy to give the patch a positive review. If you are happy to do likewise for my changes, then add yourself to the reviewer field and this can be changed to positive review.

However, it must be merged along with #10766 - neither can be done independently of the other.

Dave

[kiwifb]

comment:6

Well no change apart from the src folder and SPKG.txt and that's just what we want. The package build fine against ecl-11.1.1 and returns what we want

sage: maxima.version()
'5.23.2'
sage: maxima("next_prime(113);")
127

So it's a positive review from me. Don't forget to review and test my ecl spkg in #10766.

[kiwifb]

Changed reviewer from David Kirkby to David Kirkby, François Bissey

[sagetrac-drkirkby]

comment:8

Note to the release manager

This must be merged along with #10766 - neither can be done independently of the other. They should be upgraded as a pair.

[kcrisman]

comment:9

I have a question about the new Maxima. Did anyone else notice that it is building a lot of documentation that I don't know if it did in the past? At any rate, I am getting tons of error messages (where I didn't before) about missing nodes and so forth - also some other similar ones. It doesn't seem to affect installation, unsurprisingly, but still seems odd. It may be related to the /src folder having a new /admin subdirectory which contains another Makefile and a new TODO file that I hadn't seen before.

[kcrisman]

comment:12

Well, other than this weird documentation issue, I have no problems with this package. It passes the doctests I have time to check now on OS X 10.4 PPC (old and very slow, but hence useful for testing), and assuming it's passed more common platforms I think the changes are fine.

[kcrisman]

comment:13

Changing milestone in the hopes it will get in for 4.7 :)

[kiwifb]

comment:14

Replying to @kcrisman:

I have a question about the new Maxima. Did anyone else notice that it is building a lot of documentation that I don't know if it did in the past? At any rate, I am getting tons of error messages (where I didn't before) about missing nodes and so forth - also some other similar ones. It doesn't seem to affect installation, unsurprisingly, but still seems odd. It may be related to the /src folder having a new /admin subdirectory which contains another Makefile and a new TODO file that I hadn't seen before.

I hadn't noticed because I have been building maxima a lot (both versions 5..2.1 and 5.23.2) in sage and on the system. I compared build logs on the system and this is new. I don't know if it can be disabled yet but it may be a good idea if it can.

For the record it looks like texinfo stuff to me and it is located in doc/info.

[sagetrac-drkirkby]

comment:15

To my knowledge 4.6.2 is not in any sort of "feature freeze" yet, with no release candidates released - only alphas. So I've set this back to 4.6.2. I've asked on sage-devel if it can go in 4.6.2, but so far no response. I'd rather not wait until 4.7 if possible, as the ECL update is critical to a successful 64-bit Sage on Solaris.

Note to the release manager

This must be merged along with #10766 - neither can be done independently of the other. They should be upgraded as a pair.

[kcrisman]

comment:39

=== maxima-5.23.2 (David Kirkby, 10th Feb 2011) ===
 * #10773 Update Maxima to the latest upstream release. 
 * Starting with this version we need to touch all html and info file in doc/info, otherwise they
   get regenerated which does require texinfo.

I suppose this should have Francois as well listed. So if someone wants to revert positive review based on that - that someone being Francois - they can. On the other hand, he posted the new spkg! And it is a correctly created spkg. So I'm fine with it if he is.

[nbruin]

comment:40

Replying to @nbruin:

Perhaps a little more minimalist approach.

I tried the minimalist approach with include-maxima.texi using the original 5.23.2 package and after building, the html files still had their old stamp and I didn't see excessive building activity. So I think that trick works too. I don't know how robust "mv"s property to not change timestamps is, though, so perhaps "touch" is more portable.

[kiwifb]

comment:41

Thanks for all the testing guys. Yes I was also wondering about mv and time stamps, so touch may be safer.

I forgot to add myself - bother. Doesn't matter. I want this to be done and I am listed as an author here on trac, that's good enough.

[sagetrac-drkirkby]

comment:42

OK guys, thanks for all this. I think we are done with this now. I know I wrote this before, but it makes it clearer if at the end.

Note to the release manager

This must be merged along with #10766 - neither can be done independently of the other. They should be upgraded as a pair.

Dave

[jdemeyer]

Work Issues: build on systems without makeinfo

[jdemeyer]

comment:45

Considering the makeinfo issue has not been resolved yet, this still needs work.

[kcrisman]

comment:46

Replying to @jdemeyer:

Considering the makeinfo issue has not been resolved yet, this still needs work.

???

Dave clearly said

I uninstalled autoconf, automake and texinfo. The Maxima package built fine, and all doctests (including the long ones) passed.

And at least above it seems like makeinfo is part of texinfo. Am I missing something here?

[jdemeyer]

comment:47

Well, it doesn't work for me on sage.math.washington.edu which does not have texinfo installed.

[jpflori]

comment:48

Did you use the new (new) spkg linked in #10773 comment:31 ?

The one in the ticket description is the original new one and does not compile without makeinfo (part of makeinfo package on debian).

[sagetrac-drkirkby]

comment:49

The makeinfo problem has been resolved.

I've changed the ticket description, as that did have the old version, where the revised one produced by François Bissey builds without it. Sorry for the confusion.
I think this can be put back to positive review, but I'll leave someone else to do it.

Dave

[sagetrac-drkirkby]

Changed work issues from build on systems without makeinfo to none

[jdemeyer]

comment:51

I'll test again on sage.math.washington.edu.

[jdemeyer]

comment:52

I have tested this on sage.math.washington.edu (a system without makeinfo) and it does indeed work now.

[jdemeyer]

Merged: sage-4.7.alpha1