Update Public Suffix List to 46ac7a8060f29bd6e9ad047c8961f54a634f042cb66381894f39f442e077afd6 #877
clippy
18 warnings
Details
Results
Message level | Amount |
---|---|
Internal compiler error | 0 |
Error | 0 |
Warning | 18 |
Note | 0 |
Help | 0 |
Versions
- rustc 1.79.0-nightly (9d79cd5f7 2024-04-05)
- cargo 1.79.0-nightly (0637083df 2024-04-02)
- clippy 0.1.79 (9d79cd5 2024-04-05)
Annotations
Check warning on line 23 in src/config/redirect.rs
github-actions / clippy
this `impl` can be derived
warning: this `impl` can be derived
--> src/config/redirect.rs:19:1
|
19 | / impl Default for RedirectPolicy {
20 | | fn default() -> Self {
21 | | RedirectPolicy::None
22 | | }
23 | | }
| |_^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls
= note: `#[warn(clippy::derivable_impls)]` implied by `#[warn(clippy::all)]`
= help: remove the manual implementation...
help: ...and instead derive it...
|
5 + #[derive(Default)]
6 | pub enum RedirectPolicy {
|
help: ...and mark the default variant
|
10 ~ #[default]
11 ~ None,
|
Check warning on line 196 in src/trailer.rs
github-actions / clippy
usage of a legacy numeric method
warning: usage of a legacy numeric method
--> src/trailer.rs:196:45
|
196 | self.shared.ready.notify(usize::max_value());
| ^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
= note: `#[warn(clippy::legacy_numeric_constants)]` implied by `#[warn(clippy::all)]`
help: use the associated constant instead
|
196 | self.shared.ready.notify(usize::MAX);
| ~~~
Check warning on line 170 in src/handler.rs
github-actions / clippy
the borrowed expression implements the required traits
warning: the borrowed expression implements the required traits
--> src/handler.rs:170:42
|
170 | easy.get_mut().span.record("id", &id);
| ^^^ help: change this to: `id`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
note: the lint level is defined here
--> src/lib.rs:240:5
|
240 | clippy::all
| ^^^^^^^^^^^
= note: `#[warn(clippy::needless_borrows_for_generic_args)]` implied by `#[warn(clippy::all)]`
Check warning on line 124 in src/interceptor/mod.rs
github-actions / clippy
method `call` is never used
warning: method `call` is never used
--> src/interceptor/mod.rs:124:24
|
124 | fn call(&self, $($arg: $arg_ty,)*) -> Self::Future;
| ^^^^
...
159 | / impl_async_fn! {
160 | | (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
161 | | (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
| | -------- method in this trait
162 | | (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
163 | | }
| |_____- in this macro invocation
|
= note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 121 in src/interceptor/mod.rs
github-actions / clippy
method `call_mut` is never used
warning: method `call_mut` is never used
--> src/interceptor/mod.rs:121:24
|
121 | fn call_mut(&mut self, $($arg: $arg_ty,)*) -> Self::Future;
| ^^^^^^^^
...
159 | / impl_async_fn! {
160 | | (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
161 | | (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
| | ----------- method in this trait
162 | | (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
163 | | }
| |_____- in this macro invocation
|
= note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 118 in src/interceptor/mod.rs
github-actions / clippy
method `call_once` is never used
warning: method `call_once` is never used
--> src/interceptor/mod.rs:118:24
|
118 | fn call_once(self, $($arg: $arg_ty,)*) -> Self::Future;
| ^^^^^^^^^
...
159 | / impl_async_fn! {
160 | | (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
161 | | (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
| | ------------ method in this trait
162 | | (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
163 | | }
| |_____- in this macro invocation
|
= note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 124 in src/interceptor/mod.rs
github-actions / clippy
method `call` is never used
warning: method `call` is never used
--> src/interceptor/mod.rs:124:24
|
124 | fn call(&self, $($arg: $arg_ty,)*) -> Self::Future;
| ^^^^
...
159 | / impl_async_fn! {
160 | | (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
| | -------- method in this trait
161 | | (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
162 | | (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
163 | | }
| |_____- in this macro invocation
|
= note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 121 in src/interceptor/mod.rs
github-actions / clippy
method `call_mut` is never used
warning: method `call_mut` is never used
--> src/interceptor/mod.rs:121:24
|
121 | fn call_mut(&mut self, $($arg: $arg_ty,)*) -> Self::Future;
| ^^^^^^^^
...
159 | / impl_async_fn! {
160 | | (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
| | ----------- method in this trait
161 | | (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
162 | | (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
163 | | }
| |_____- in this macro invocation
|
= note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 118 in src/interceptor/mod.rs
github-actions / clippy
method `call_once` is never used
warning: method `call_once` is never used
--> src/interceptor/mod.rs:118:24
|
118 | fn call_once(self, $($arg: $arg_ty,)*) -> Self::Future;
| ^^^^^^^^^
...
159 | / impl_async_fn! {
160 | | (AsyncFnOnce0, AsyncFnMut0, AsyncFn0, ()),
| | ------------ method in this trait
161 | | (AsyncFnOnce1, AsyncFnMut1, AsyncFn1, (a0:A0, )),
162 | | (AsyncFnOnce2, AsyncFnMut2, AsyncFn2, (a0:A0, a1:A1, )),
163 | | }
| |_____- in this macro invocation
|
= note: `#[warn(dead_code)]` implied by `#[warn(unused)]`
= note: this warning originates in the macro `impl_async_fn` (in Nightly builds, run with -Z macro-backtrace for more info)
Check warning on line 7 in src/config/tls.rs
github-actions / clippy
the item `FromIterator` is imported redundantly
warning: the item `FromIterator` is imported redundantly
--> src/config/tls.rs:7:5
|
7 | iter::FromIterator,
| ^^^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `FromIterator` is already defined here
Check warning on line 4 in src/config/request.rs
github-actions / clippy
the item `Easy2` is imported redundantly
warning: the item `Easy2` is imported redundantly
--> src/config/request.rs:4:5
|
3 | use super::{proxy::Proxy, *};
| - the item `Easy2` is already imported here
4 | use curl::easy::Easy2;
| ^^^^^^^^^^^^^^^^^
Check warning on line 3 in src/config/request.rs
github-actions / clippy
the item `Proxy` is imported redundantly
warning: the item `Proxy` is imported redundantly
--> src/config/request.rs:3:13
|
3 | use super::{proxy::Proxy, *};
| ^^^^^^^^^^^^ - the item `Proxy` is already imported here
Check warning on line 3 in src/config/proxy.rs
github-actions / clippy
the item `FromIterator` is imported redundantly
warning: the item `FromIterator` is imported redundantly
--> src/config/proxy.rs:3:5
|
3 | use std::iter::FromIterator;
| ^^^^^^^^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `FromIterator` is already defined here
Check warning on line 7 in src/config/dial.rs
github-actions / clippy
the item `TryFrom` is imported redundantly
warning: the item `TryFrom` is imported redundantly
--> src/config/dial.rs:7:11
|
7 | use std::{convert::TryFrom, fmt, net::SocketAddr, str::FromStr};
| ^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `TryFrom` is already defined here
Check warning on line 11 in src/redirect.rs
github-actions / clippy
the item `TryFrom` is imported redundantly
warning: the item `TryFrom` is imported redundantly
--> src/redirect.rs:11:24
|
11 | use std::{borrow::Cow, convert::TryFrom, fmt::Write, str};
| ^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `TryFrom` is already defined here
Check warning on line 28 in src/client.rs
github-actions / clippy
the item `TryFrom` is imported redundantly
warning: the item `TryFrom` is imported redundantly
--> src/client.rs:28:5
|
28 | convert::TryFrom,
| ^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `TryFrom` is already defined here
Check warning on line 12 in src/cookies/interceptor.rs
github-actions / clippy
the item `TryInto` is imported redundantly
warning: the item `TryInto` is imported redundantly
--> src/cookies/interceptor.rs:12:5
|
12 | use std::convert::TryInto;
| ^^^^^^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `TryInto` is already defined here
Check warning on line 249 in src/lib.rs
github-actions / clippy
the item `TryFrom` is imported redundantly
warning: the item `TryFrom` is imported redundantly
--> src/lib.rs:249:5
|
249 | use std::convert::TryFrom;
| ^^^^^^^^^^^^^^^^^^^^^
--> /rustc/9d79cd5f79e75bd0d2083260271307ce9acd9081/library/std/src/prelude/mod.rs:148:13
|
= note: the item `TryFrom` is already defined here
|
note: the lint level is defined here
--> src/lib.rs:238:5
|
238 | unused,
| ^^^^^^
= note: `#[warn(unused_imports)]` implied by `#[warn(unused)]`