This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Read source resources correctly #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 20, 2019 13:49
**What** - Use correct types for values passed to `Set` **Why** The package that terraform uses `github.com/mitchellh/mapstructure` to decode values, does not support `sql.NullString`. All the calls to `d.Set` were returning errors. For whatever reason, ignoring errors is common practice throughout various terraform providers so we're not changing that here. This change passes the correct primitives and in our cases, none of the values can be null in the database so there is no need for `sql.NullString`.
malexovi
reviewed
Feb 4, 2020
| @@ -182,35 +164,14 @@ func readWarehouse(d *schema.ResourceData, meta interface{}) error { | |||
| return fmt.Errorf("Error during show create warehouse: %s", err) | |||
| } | |||
|
|
|||
| //Properties | |||
There was a problem hiding this comment.
Is this dropping the ability to configure these properties on a warehouse? If so, why?
There was a problem hiding this comment.
It is not. It is cleaning up values that were unused but enumerated here for whatever reason. The original author, shoprunner, just dumped everything in here and actually specified some properties in the schema that are not actually set on the warehouse
The only props supported are enumerated here
malexovi
approved these changes
Jul 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
SetWhy
The package that terraform uses
github.com/mitchellh/mapstructureto decode values, does not supportsql.NullString.All the calls to
d.Setwere returning errors. For whatever reason, ignoring errors is common practice throughout various terraform providers so we're not changing that here.This change passes the correct primitives and in our cases, none of the values can be null in the database so there is no need for
sql.NullString.Testing