updates to implementation of allowing mouse input on search field #1211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted item in addition to search, reordering the z-indexes of search and selected to allow for clicks on the selected item, update unit tests accordingly
|
Thanks for this @dkurucz! I will dig in to the issue in the next few days. |
|
Could it be merged? I am stuck at version 3.10.2 because of a regression introduced by this PR : #1092 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR:
This updated implementation allows the user to click on the selected item(s) allowing for events to fire in situations involving templates. Prior to this, the search field was reordered to allow it to cover the selected items and stop the click events intentionally.
Unit tests are also updated to reflect the logic in place.