Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace renameio.WriteFile with version that is compatible to windows #8

Merged
2 commits merged into from
Aug 23, 2019

Conversation

dhaavi
Copy link
Member

@dhaavi dhaavi commented Aug 21, 2019

Temporary fix until https://github.com/google/renameio fixes WriteFile for windows.

Issue: google/renameio#17

@dhaavi dhaavi requested a review from a user August 21, 2019 13:32
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the tests fail even more: Googles renameio.writeFile() heavily relies on renameio.TempFile() and makes build fail even on Linux (and on my system).

additionally the removed chmod maybe add security implications

If you want, I can also look if I can fix that ...

@dhaavi
Copy link
Member Author

dhaavi commented Aug 22, 2019

This makes the tests fail even more: Googles renameio.writeFile() heavily relies on renameio.TempFile() and makes build fail even on Linux (and on my system).

Seems to have been just a "typo" 🙈

additionally the removed chmod maybe add security implications

That could be true in the future. Right now, the permissions on all preceding folders would prevent security issues. Fixed for Linux.

@dhaavi dhaavi requested a review from a user August 22, 2019 20:42
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additionally the removed chmod maybe add security implications

That could be true in the future. Right now, the permissions on all preceding folders would prevent security issues. [..]

At first the tempfile is created in something like C:\Users\travis\AppData\Local\Temp, so here the permissions will be restricted enough, you are right ...

@ghost ghost merged commit fc8fe2a into develop Aug 23, 2019
@ghost ghost deleted the fix/fstree-storage-windows branch August 23, 2019 06:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant