Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Push notifications toggle #4254

Merged
merged 1 commit into from
Sep 27, 2024
Merged

fix: Push notifications toggle #4254

merged 1 commit into from
Sep 27, 2024

Conversation

usame-algan
Copy link
Member

What it solves

Resolves #4253

How this PR fixes it

How to test it

  1. Open a Safe
  2. Go to Notification settings
  3. Turn on notifications
  4. Sign the message
  5. Observe the Toggle turns on

Screenshots

Screenshot 2024-09-26 at 11 44 21

Checklist

  • I've tested the branch on mobile 📱
  • I've documented how it affects the analytics (if at all) 📊
  • I've written a unit/e2e test for it (if applicable) 🧑‍💻

Copy link

github-actions bot commented Sep 26, 2024

@usame-algan usame-algan marked this pull request as ready for review September 26, 2024 09:48
Copy link

📦 Next.js Bundle Analysis for safe-wallet-web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

One Page Changed Size

The following page changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/settings/notifications 27.03 KB (🟡 +10 B) 981.51 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

Copy link

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
78.22% (+0.01% 🔼)
11993/15333
🔴 Branches
58.27% (+0.02% 🔼)
3087/5298
🟡 Functions 65.27% 1889/2894
🟡 Lines
79.73% (+0.01% 🔼)
10824/13576

Test suite run success

1484 tests passing in 203 suites.

Report generated by 🧪jest coverage report action from f2e13ab

@@ -19,7 +20,7 @@ const registrationFlow = async (registrationFn: Promise<unknown>, callback: () =

// Gateway will return 200 with an empty payload if the device was (un-)registered successfully
// @see https://github.com/safe-global/safe-client-gateway-nest/blob/27b6b3846b4ecbf938cdf5d0595ca464c10e556b/src/routes/notifications/notifications.service.ts#L29
success = response == null
success = isEmpty(response)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this check? If we get to this point then we've gotten a 200, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think so otherwise if it threw we would end up in the catch. I assume this was added in case the response is successful but not empty. For now I would leave it as is since the notifications are being reworked on the service side so we will have to touch this again anyway.

@liliya-soroka
Copy link
Member

Verified
Toggle works but , notifications are not received.
The issue was reported to the protocol team

@usame-algan usame-algan merged commit 5087ae8 into dev Sep 27, 2024
15 checks passed
@usame-algan usame-algan deleted the fix-notification-toggle branch September 27, 2024 07:59
@github-actions github-actions bot locked and limited conversation to collaborators Sep 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not enable notifications for one safe
4 participants