Add Delegates events on creation/deletion/update #2310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have continued the use of signals to manage the sending of these events to the queue because as we currently have multiple endpoints for delegate management the solution is simpler and clearer. At the moment, the delegates management is not high and there should not be performance issues with the use of signals. |
Uxio0
requested changes
Nov 6, 2024
| delegate: str | ||
| delegator: str | ||
| label: str | ||
| expiryDate: Optional[int] |
There was a problem hiding this comment.
Maybe add the unit, for clarity. Like expiryDateSeconds
There was a problem hiding this comment.
Done e90cc85
safe_transaction_service/history/services/notification_service.py
Outdated
Show resolved
Hide resolved
safe_transaction_service/history/services/notification_service.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Uxío <[email protected]>
Co-authored-by: Uxío <[email protected]>
Uxio0
approved these changes
Nov 7, 2024
iamacook
reviewed
Nov 7, 2024
iamacook
approved these changes
Nov 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes Add Delegates events on creation/deletion/update #2299
Added the new event types: NEW_DELEGATE, UPDATED_DELEGATE and DELETED_DELEGATE