Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Safe-transaction arbitrum - "list.remove(x): x not in list" #2307

Closed
luarx opened this issue Nov 5, 2024 · 0 comments · Fixed by #2333
Closed

Safe-transaction arbitrum - "list.remove(x): x not in list" #2307

luarx opened this issue Nov 5, 2024 · 0 comments · Fixed by #2333
Assignees
@falvaradorodriguez @Uxio0
Labels
bug Something isn't working

Comments

@luarx
Copy link
Contributor

luarx commented Nov 5, 2024

Describe the bug

process_decoded_transactions
    results.append(self.__process_decoded_transaction(internal_tx_decoded))
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/app/safe_transaction_service/history/indexers/tx_processor.py", line 514, in __process_decoded_transaction
    safe_last_status.enabled_modules.remove(arguments["module"])
ValueError: list.remove(x): x not in list
@luarx luarx added the bug Something isn't working label Nov 5, 2024
@falvaradorodriguez falvaradorodriguez self-assigned this Nov 18, 2024
@falvaradorodriguez falvaradorodriguez mentioned this issue Nov 19, 2024
Merged
@Uxio0 Uxio0 self-assigned this Nov 19, 2024
Uxio0 added a commit that referenced this issue Nov 19, 2024
@Uxio0
Handle module removal exceptions
8a5b662 
- Tx processor was not handling propertly errors removing modules
- Closes #2307
@Uxio0 Uxio0 mentioned this issue Nov 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@falvaradorodriguez falvaradorodriguez

@Uxio0 Uxio0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
3 participants
@falvaradorodriguez @Uxio0 @luarx