Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3406 testing option of crash due to subtraction overflow #3421

Merged
merged 2 commits into from
May 31, 2024
Merged

GH-3406 testing option of crash due to subtraction overflow #3421

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ffc02f
GH-3406 testing option of crash due to subtraction overflow
DmitryBespalov May 31, 2024
76753a7
GH-3406 use if-else for better line location
DmitryBespalov May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions Multisig/UI/Settings/OwnerKeyManagement/KeystoneOwnerKey/KeystoneSignFlow.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,12 @@ extension SECP256K1.UnmarshaledSignature {
} else {
// v still can be `{0, 1} + chainId * 2 + 35` for non-legacy transactions (chainId >=0)
if vInt >= 35 {
let vRecovered = UInt64(vBytes) - chainIdTerm
v = try! UInt8(vRecovered)
if chainIdTerm > UInt64(vBytes) {
v = 0
} else {
let vRecovered = UInt64(vBytes) - chainIdTerm
v = try! UInt8(vRecovered)
}
} else {
v = vInt
}
Expand Down
Loading