Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gh 2464/ipad ledger #3403

Merged
merged 11 commits into from
Apr 22, 2024
Merged

Gh 2464/ipad ledger #3403

merged 11 commits into from
Apr 22, 2024

Conversation

DmitryBespalov
Copy link
Contributor

Handles #3288

Changes proposed in this pull request:

  • crash fixes attempt

Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 134 lines in your changes are missing coverage. Please review.

Project coverage is 8.27%. Comparing base (dae8ae4) to head (bb844ac).
Report is 2 commits behind head on main.

Files Patch % Lines
...Connect to Web/Logic/WebConnectionController.swift 0.00% 58 Missing ⚠️
...ings/Passcode/SecuritySettingsViewController.swift 0.00% 11 Missing ⚠️
...afesViewController/SwitchSafesViewController.swift 0.00% 8 Missing ⚠️
...ViewController/OwnerKeyDetailsViewController.swift 0.00% 8 Missing ⚠️
...erViewController/QRCodeScannerViewController.swift 0.00% 8 Missing ⚠️
...dressBook/AddressBookListTableViewController.swift 0.00% 6 Missing ⚠️
...stViewController/OwnerKeysListViewController.swift 0.00% 5 Missing ⚠️
.../Passcode/Create Passcode/CreatePasscodeFlow.swift 0.00% 4 Missing ⚠️
Multisig/Data/Services/Utils/GSError.swift 0.00% 3 Missing ⚠️
...ngsViewController/SafeSettingsViewController.swift 0.00% 3 Missing ⚠️
... and 10 more
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #3403      +/-   ##
========================================
- Coverage   8.27%   8.27%   -0.01%     
========================================
  Files        789     788       -1     
  Lines      44082   44084       +2     
========================================
  Hits        3647    3647              
- Misses     40435   40437       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmitryBespalov DmitryBespalov merged commit 9caeaeb into main Apr 22, 2024
2 of 4 checks passed
@DmitryBespalov DmitryBespalov deleted the GH-2464/ipad-ledger branch April 22, 2024 12:18
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant