gh-1868 Save gas price sources to the database and use when estimatin… #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitryBespalov
commented
Feb 1, 2022
| // find the first 'fixed' gas price | ||
| var fixedGasPrice: Sol.UInt256? = nil | ||
|
|
||
| for case SCGModels.GasPrice.fixed(let fixed) in chain.gasPrice where Sol.UInt256(fixed.weiValue) != nil { |
There was a problem hiding this comment.
something new in Swift for me today
MouazAlzahabi
approved these changes
Feb 1, 2022
Codecov Report
@@ Coverage Diff @@
## main #1880 +/- ##
==========================================
- Coverage 10.31% 10.29% -0.03%
==========================================
Files 519 519
Lines 24792 24842 +50
==========================================
Hits 2557 2557
- Misses 22235 22285 +50
Continue to review full report at Codecov.
|
DmitryBespalov
deleted the
gh-1868/support-fixed-gas-prices-based-on-chain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g transaction
Handles #1868
Changes proposed in this pull request: