Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebLinks] Create and load safe #3305

Open
DmitryBespalov opened this issue Aug 23, 2023 · 2 comments
Open

[WebLinks] Create and load safe #3305

DmitryBespalov opened this issue Aug 23, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@DmitryBespalov
Copy link
Contributor

DmitryBespalov commented Aug 23, 2023

Variables

safe-address = chain-prefix : checksummed-address

chain-prefix = short name of a chain, such as 'eth', 'matic' or 'gno',
    according to the https://safe-client.safe.global/v1/chains 'shortName' field

checksummed-address = ethereum & evm-chain address in a hexadecimal, 
    checksummed format according to https://eips.ethereum.org/EIPS/eip-55

Routes

/new-safe/loadModal Load Existing Safe
load new safe flow

/new-safe/load?chain=chain-prefix&address=checksummed-address
pre-select the chain and fill in the safe address

/new-safe/load?chain=chain-prefix
pre-select the chain

/new-safe/load?address=safe-address
pre-select the chain and safe address from the eip-3770 safe address

/new-safe/createModal Create Safe
create new safe flow

/new-safe/create?chain=chain-prefixModal Create Safe
pre-select the chain

Originally posted by @DmitryBespalov in #3297 (comment)

@DmitryBespalov DmitryBespalov added the enhancement New feature or request label Aug 23, 2023
@DmitryBespalov DmitryBespalov self-assigned this Aug 23, 2023
DmitryBespalov added a commit that referenced this issue Aug 23, 2023
- Re-configured view controllers into a UIFlow
DmitryBespalov added a commit that referenced this issue Aug 24, 2023
DmitryBespalov added a commit that referenced this issue Aug 24, 2023
DmitryBespalov added a commit that referenced this issue Aug 28, 2023
DmitryBespalov added a commit that referenced this issue Aug 28, 2023
DmitryBespalov added a commit that referenced this issue Aug 28, 2023
GH-3305 handle chain and address parameters; createSafe route
@liliya-soroka
Copy link
Member

@DmitryBespalov , is it expected that navigation works only if the app is called from the background and doesn't work if it's cold app call

app version 3.23.0 (1951)

@liliya-soroka liliya-soroka added the Question? Further information is requested label Sep 5, 2023
@DmitryBespalov
Copy link
Contributor Author

@liliya-soroka that's a good one, I overlooked it

@DmitryBespalov DmitryBespalov added wontfix This will not be worked on and removed Question? Further information is requested labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants