Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blog): truncate featured article title and excerpt #467

Merged
merged 2 commits into from
Oct 1, 2024

Conversation

DiogoSoaress
Copy link
Member

@DiogoSoaress DiogoSoaress commented Sep 25, 2024

What it solves

Resolves #452

How this PR fixes it

  • Truncates the Featured post title and excerpt

Other changes

  • CMS: limited the number of chars in a blog post title to 75

How to test it

Navigate to /press or /blog and verify the Featured article layout is responsive without breaking the image content

Screenshot 2024-09-25 at 14 57 50

Copy link

github-actions bot commented Sep 25, 2024

Branch preview

✅ Deployed successfully in branch deployment:

https://fix_limit_excerpt_lines--homepage.review.5afe.dev

@DiogoSoaress
Copy link
Member Author

@TanyaEfremova please comment if the current implementation solves the issue #452

@DiogoSoaress DiogoSoaress changed the title fix(Blog): truncate featured article title and excerpt fix(blog): truncate featured article title and excerpt Sep 26, 2024
@TanyaEfremova
Copy link
Contributor

LGTM!

@DiogoSoaress DiogoSoaress merged commit 52dbf57 into main Oct 1, 2024
4 checks passed
@DiogoSoaress DiogoSoaress deleted the fix-limit-excerpt-lines branch October 1, 2024 10:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Blog] Excerpt in the highlighted article breaks the article image layout
3 participants