feat(Press room): use the latest press release in the Press Room landing page #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch preview✅ Deployed successfully in branch deployment: https://feature_latest_press_release--homepage.review.5afe.dev |
iamacook
approved these changes
Sep 23, 2024
| @@ -23,7 +24,7 @@ const PressReleases = ({ allPosts }: { allPosts: PostEntryCollection }) => { | |||
| const { localAllPosts } = useAllPosts(allPosts) | |||
|
|
|||
| const filteredPosts = useMemo(() => { | |||
| const pressPosts = localAllPosts.items.filter(isPressReleasePost) | |||
| const pressPosts = localAllPosts.items.filter((post) => isPressReleasePost(post) && !isDraft(post)) | |||
There was a problem hiding this comment.
The two instances where isPressReleasePost is used, now included a non-draft check. Should we this the "default", and moved into the helper (or a combined one added)?
There was a problem hiding this comment.
Yes, I agree it should be combined in the helper. Good suggestion!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
limitof 150 blog articles on buildfeaturedfield