Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Gnosis Protocol libraries to Cowswap #778

Merged

Conversation

falvaradorodriguez
Copy link
Contributor

@falvaradorodriguez falvaradorodriguez commented Feb 15, 2024

closes #777

Points of interest:

  • Changes indicated in the task are made.

  • The type of the "appData" parameter is changed to string. CowSwap API requires a string in that parameter instead of the existing hash. A JSON string with the format defined here should be specified in the parameter.

  • The existing configuration for using Goerli Testnet is removed.

  • The necessary modifications are made to the TestEtherscanClient based on the above and the test skip is removed.

  • The CLI client is moved to the scripts folder.

@falvaradorodriguez falvaradorodriguez requested a review from a team as a code owner February 15, 2024 15:57
@falvaradorodriguez falvaradorodriguez requested review from fmrsabino, moisses89, iamacook and Uxio0 and removed request for a team February 15, 2024 15:57
@falvaradorodriguez falvaradorodriguez marked this pull request as draft February 15, 2024 15:58
@falvaradorodriguez falvaradorodriguez marked this pull request as ready for review February 15, 2024 16:04
Copy link
Member

@Uxio0 Uxio0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice PR @falvaradorodriguez , there are 2 small suggestions and you are good to merge!

docs/source/quickstart.rst Outdated Show resolved Hide resolved
docs/source/quickstart.rst Outdated Show resolved Hide resolved
scripts/cowswap/cow_swap_cli.py Outdated Show resolved Hide resolved
@falvaradorodriguez falvaradorodriguez merged commit 36d29ad into master Feb 16, 2024
7 checks passed
@falvaradorodriguez falvaradorodriguez deleted the rename-gnosis-protocol-libraries-to-cowswap branch February 16, 2024 09:54
@github-actions github-actions bot locked and limited conversation to collaborators Feb 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename Gnosis Protocol libraries to Cowswap
2 participants