Deprecate executedSurplusFee
, adding executedFee
and executedFeeToken
#2247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
executedSurplusFee
is being deprecated, in favour ofexecutedFee
andexecutedFeeToken
. This deprecates the formers, and adds the latter toOrder
s.Eventually, the
executedFeeToken
will also need updating as it will will be expressed in SURPLUS tokens (BUY tokens for SELL orders and SELL tokens for BUY orders). For now, it remains thesellToken
.Note: all fields are no longer nullable, apart from previewed TWAP parts.
Changes
executedFee
/executedFeeToken
toOrderSchema
.executedSurplusFee
<>executedFee
andsellToken
<>executedFeeToken
.