Fixed VaultEditorDialog EditorImpl memory leak

sadv1r · May 13, 2021 · fe84a5c · fe84a5c
1 parent d625311
commit fe84a5c
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/main/kotlin/ru/sadv1r/idea/plugin/ansible/vault/editor/ui/VaultEditorDialog.kt b/src/main/kotlin/ru/sadv1r/idea/plugin/ansible/vault/editor/ui/VaultEditorDialog.kt
@@ -20,6 +20,7 @@ class VaultEditorDialog(
 ) : DialogWrapper(true) {
 
     private lateinit var decryptedDocument: Document
+    private lateinit var editor: EditorEx
 
     init {
         init()
@@ -34,7 +35,7 @@ class VaultEditorDialog(
             decryptedDocumentData.toString(Charsets.UTF_8).trim().replace("\r\n|\r".toRegex(), "\n")
         )
         decryptedDocument.setReadOnly(false)
-        val editor: EditorEx = editorFactory.createEditor(decryptedDocument) as EditorEx
+        editor = editorFactory.createEditor(decryptedDocument) as EditorEx
 
         setHighlighting(editor)
         editor.setCaretEnabled(true)
@@ -53,6 +54,12 @@ class VaultEditorDialog(
         }
     }
 
+    override fun dispose() {
+        EditorFactory.getInstance().releaseEditor(editor)
+
+        super.dispose()
+    }
+
     private fun setHighlighting(editor: EditorEx) {
         val fileType = vault.getFileType()
         if (fileType === UnknownFileType.INSTANCE) {