Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving masking mechanisms in CNN and LightAttention models #102

Merged
merged 5 commits into from
Aug 19, 2024

Conversation

SebieF
Copy link
Collaborator

@SebieF SebieF commented Aug 13, 2024

  • Applying masking to CNN: Padded residue embeddings are now masked out which improves reproducibility and avoids different predictions between batches and single inputs
  • Improving masking in LightAttention model: Mask is now applied before the attention convolution, and -float('inf') is used instead of -1e9 which seems to improve reproducibility and avoids different predictions between batches and single inputs
  • Adding inference unit test to check if batch predictions match single predictions
  • Updating models and related inference unit tests

Closes #100.

SebieF added 5 commits August 13, 2024 15:40
Padded residue embeddings are now masked out which improves reproducibility and avoids different predictions between batches and single inputs
Mask is now applied before the attention convolution, and `-float('inf')` is used instead of `-1e9` which seems to improve reproducibility and avoids different predictions between batches and single inputs
@SebieF SebieF added bug Something isn't working testing Related to automated tests breaking Breaking change labels Aug 13, 2024
@SebieF SebieF self-assigned this Aug 13, 2024
@SebieF SebieF merged commit 5d49ad3 into sacdallago:develop Aug 19, 2024
1 check passed
@SebieF SebieF deleted the bugfix/embeddings-padding branch August 19, 2024 07:31
@SebieF SebieF mentioned this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change bug Something isn't working testing Related to automated tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant