This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
2DSE: Hidden surface removal and optimized NoCSG. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had this thought in the back of mind that it should be possible to detect what surfaces are hidden and to exclude those automatically. I just had to try it.
By excluding hidden surfaces it automatically optimizes NoCSG brushes the same way additive brushes would have. At first I wanted to make this a special feature just for NoCSG brushes. But it turns out it also excludes a couple faces that CSG doesn't exclude due to floating point precision errors. This is especially noticeable with complex revolved shapes.
So this hidden surface removal algorithm is now a default part of the brush building algorithm.