Skip to content
This repository was archived by the owner on Feb 11, 2024. It is now read-only.

Cleaned up the shaders. Backwards compatibility with Unity 5.3.0f4. #50

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

Henry00IS
Copy link
Collaborator

@Henry00IS Henry00IS commented Mar 7, 2018

  • Cleaned up the source code of all of the shaders (edit: indentation and line breaks only).
  • Removed warnings about "There are inconsistent line endings".
  • Took care of "Upgrade NOTE: replaced 'mul(UNITY_MATRIX_MVP,)' with 'UnityObjectToClipPos()'"

Removed warnings about "There are inconsistent line endings".
Took care of "Upgrade NOTE: replaced 'mul(UNITY_MATRIX_MVP,*)' with 'UnityObjectToClipPos(*)'"
@sabresaurus
Copy link
Owner

The reason I haven't committed these files before is I''m not sure these shaders will compile on Unity 5.0 (our min spec). I'll install Unity 5.0 again and double check

@Henry00IS
Copy link
Collaborator Author

Henry00IS commented Mar 18, 2018

I installed Unity 5.0.0f4 from March 2015 and barely anything compiles. There are many C# errors. I figured perhaps you meant the 5.x series in general?

As we have UNITY_5_3_OR_NEWER comments I then tried Unity 5.3.0f4 from December 2015. I provided an implementation of Vector2Int and fixed the shaders (and a couple more small C# errors), you were right. So now our minimum version is 5.3.0f4.

@Henry00IS Henry00IS changed the title Cleaned up the source code of all of the shaders. Cleaned up the shaders. Backwards compatibility with Unity 5.3.0f4. Mar 18, 2018
@Henry00IS Henry00IS merged commit 71eebfa into sabresaurus:master Mar 27, 2018
@Henry00IS Henry00IS deleted the ShaderCleanup branch March 27, 2018 19:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants