Skip to content
This repository has been archived by the owner on Feb 11, 2024. It is now read-only.

Additional Features for Curved Staircase Compound Brushes #30

Merged
merged 4 commits into from
Jan 30, 2018

Conversation

Henry00IS
Copy link
Collaborator

  • Added "Fill To Bottom" identical to the linear staircases.
  • Added "Build Torus" to easily build walls around curved staircases.
  • Fixed the normals for "Counter Clockwise" mode.
  • Updated the inspector to use more of a SabreCSG theme.
  • Moved some identical copy and pasted code into separate functions.

newcurvedstairfeatures

Added "Fill To Bottom" identical to the linear staircases.
Added "Build Torus" to easily build walls around curved staircases.
Fixed the normals for "Counter Clockwise" mode.
Updated the inspector to use more of a SabreCSG theme.
Moved some identical copy and pasted code into separate functions.
Added sloped floor to build beautiful ramps.
Fixed the normals for "Counter Clockwise" mode.
Improved the automatic UV mapping.
Added sloped ceiling to build beautiful ramps.
@Henry00IS
Copy link
Collaborator Author

Added beautiful sloped floors and ceilings that can both be combined for amazing things.
image
image

This pull request can be reviewed and merged now.

@sabresaurus
Copy link
Owner

I'd suggest renaming "Build Torus" to something else. A torus is a donut shape, this is technically a hollow cylinder. I'd probably also suggest splitting out that function into a separate compound brush, from a user's perspective it doesn't really make sense to create a stair brush which you then turn into an arch/curved wall.

@sabresaurus
Copy link
Owner

Other than that this looks great

@Henry00IS
Copy link
Collaborator Author

Henry00IS commented Jan 29, 2018

The reason the torus (what's a better name for it? maybe "walls") was added is to make walls around curved staircases. The default cylinder doesn't align properly. This Zelda Ocarina of Time level is where I got the inspiration to include that feature. How else are you ever going to make such a corridor?

Specifically note that there are straight parts as well as curved parts. That's nearly impossible to do without this feature.

@Henry00IS
Copy link
Collaborator Author

Henry00IS commented Jan 30, 2018

This is its intended use:

image

Edit: Should have reduced the step count in the middle section to make it the same depth as the others. But I rushed this example in the middle of the night.

@sabresaurus sabresaurus merged commit df20e52 into sabresaurus:master Jan 30, 2018
@Henry00IS Henry00IS deleted the CurvedStairsFeatures branch January 31, 2018 10:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants