This repository has been archived by the owner on Feb 11, 2024. It is now read-only.
Fixed the deselecting of faces that are behind the face you clicked on #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…accidentally select/deselect polygons behind the one we see. A very annoying bug that was fixed by removing a lot of code that apparently doesn't do anything useful.
|
This was added to support cycle click of faces. When you click on a face, subsequent clicks allow you to cycle through other hits. It's something we do with both the brush selection and the face tool, in addition Unity does it too. I'm not sure removing cycle click support is the correct fix for this |
…fier keys does a special action, that's either rotating on CTRL (which is actually behaving like this already) or quick select on SHIFT. Now we got every feature!
|
Thank you! Now I finally understand! The good news is I found the perfect solution. Clicking without any modifier keys does the cycling and with modifier keys does the special action, that's either rotating on CTRL (which is actually behaving like this already) or quick select on SHIFT. Now we got every feature! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SurfaceEditor: We now use the first polygon that was hit so we don't accidentally select/deselect polygons behind the one we see. A very annoying bug that was fixed by removing a lot of code that apparently doesn't do anything useful.
Correct me if I am wrong, but I tried everything I could think of and it works perfectly, I have no idea what all that code was doing.
Also to replicate the bug I am talking about, select a face, move your camera so it's covered by another face, try selecting that one, the face behind it will be deselected and the face you clicked stays deselected. An annoying bug because the wrong raycast hits were used instead of the first. I found the solution by looking at how CTRL-click does it on mouse-up where you already fixed this problem the same way. "// User is trying to multiselect, let's not make life difficult for them, by only accepting the nearest polygon".